From e41079741325680c55a9573a3576f03232390b46 Mon Sep 17 00:00:00 2001 From: Alejandro Mery Date: Sat, 2 Mar 2024 21:53:33 +0000 Subject: [PATCH] env: use foo= instead of foo="" for empty variables to improve readability Signed-off-by: Alejandro Mery --- pkg/cluster/env.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/cluster/env.go b/pkg/cluster/env.go index cf5b171..a6c4b89 100644 --- a/pkg/cluster/env.go +++ b/pkg/cluster/env.go @@ -117,7 +117,11 @@ func (m *Env) writeEnvVar(w io.Writer, value string, name string, args ...any) { if name != "" { value = strings.TrimSpace(value) - _, _ = fmt.Fprintf(w, "%s%s=%q\n", prefix, name, value) + if value == "" { + _, _ = fmt.Fprintf(w, "%s%s=\n", prefix, name) + } else { + _, _ = fmt.Fprintf(w, "%s%s=%q\n", prefix, name, value) + } } }