amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ceph: generate fsid if needed, and export FSID on env #10

Merged
amery merged 3 commits from pr-amery-ceph-fsid into main 2023-09-05 22:13:10 +02:00
Conversation 3 Commits 3 Files Changed 4
+29 -6
amery commented 2023-09-05 21:55:51 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 3 commits 2023-09-05 21:55:52 +02:00
vscode: add gofrs to the dictionary 3911a51ccf 
as we use "github.com/gofrs/uuid/v5"

Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: improve GetCephFSID() to generate a new UUID if none was found 84d380ae73 
Signed-off-by: Alejandro Mery <amery@jpi.io>
env: export FSID c2a21707c9 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery force-pushed pr-amery-ceph-fsid from c2a21707c9 to a655603343 2023-09-05 21:57:45 +02:00 Compare
amery commented 2023-09-05 21:58:14 +02:00
Author
Owner
Copy Link
Copy Source

fixed GetCephFSID() to actually return the error

fixed `GetCephFSID()` to actually return the error
karasz approved these changes 2023-09-05 22:02:50 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTM

LGTM
🚀 1
amery merged commit e03e5e0d05 into main 2023-09-05 22:13:10 +02:00
amery deleted branch pr-amery-ceph-fsid 2023-09-05 22:13:10 +02:00
amery commented 2023-09-05 22:40:02 +02:00
Author
Owner
Copy Link
Copy Source

v0.5.1 tagged

`v0.5.1` tagged
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#10
Delete Branch "pr-amery-ceph-fsid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?