amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

zones: pass logger from cmd to Zones, Zone, and Machine #12

Merged
amery merged 3 commits from pr-amery-log into main 2023-09-08 14:41:35 +02:00
Conversation 1 Commits 3 Files Changed 9
+91 -5
amery commented 2023-09-07 20:41:11 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 3 commits 2023-09-07 20:41:11 +02:00
zones: introduce WithLogger() scan option 45447275a7 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: introduce (private) logger interface 5e5958d22e 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: add logger to Zone and Machine 1bca1f7da1 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-09-07 21:10:29 +02:00
karasz approved these changes 2023-09-08 09:59:16 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTM

LGTM
amery merged commit 8c32b88e24 into main 2023-09-08 14:41:35 +02:00
amery deleted branch pr-amery-log 2023-09-08 14:41:35 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#12
Delete Branch "pr-amery-log"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?