amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

move pkg/zones to pkg/cluster and other rearrangements #18

Merged
amery merged 5 commits from pr-amery-cluster into main 2023-09-11 20:41:26 +02:00
Conversation 3 Commits 5 Files Changed 22
+339 -305
amery commented 2023-09-11 17:38:52 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 5 commits 2023-09-11 17:38:53 +02:00
cluster: rename pkg/zones to pkg/cluster f18202b332 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: move Machines to a dedicated file f1a3606016 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: rename Zones to Cluster 36f1619d69 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: group default option factories 52774336c2 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: make domain, basedir and cluster name public fields c9314b3b7c 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-09-11 17:38:57 +02:00
karasz requested changes 2023-09-11 19:05:04 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

please rebase, but other than that LGTM

please rebase, but other than that LGTM
👍 1
amery added 5 commits 2023-09-11 20:12:31 +02:00
cluster: rename pkg/zones to pkg/cluster 5abb4c2f92 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: move Machines to a dedicated file bedf62977f 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: rename Zones to Cluster 24059dc9ee 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: group default option factories 2a2e6c121e 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: make domain, basedir and cluster name public fields d0b0698c10 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-09-11 20:12:41 +02:00
amery commented 2023-09-11 20:12:57 +02:00
Author
Owner
Copy Link
Copy Source

@karasz rebased

@karasz rebased
amery merged commit 3de7fcb605 into main 2023-09-11 20:41:26 +02:00
amery deleted branch pr-amery-cluster 2023-09-11 20:41:26 +02:00
amery commented 2023-09-11 20:42:35 +02:00
Author
Owner
Copy Link
Copy Source

v0.6.0 tagged

`v0.6.0` tagged
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#18
Delete Branch "pr-amery-cluster"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?