amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

jpictl: introduce jpictl dns show command #27

Merged
amery merged 4 commits from pr-amery-dns-show into main 2023-10-24 15:54:20 +02:00
Conversation 2 Commits 4 Files Changed 7
+171 -52
amery commented 2023-10-24 01:16:42 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 3 commits 2023-10-24 01:16:42 +02:00
dns: refactor GetRecords() to allow commands other than sync b0f4be7047 
Signed-off-by: Alejandro Mery <amery@jpi.io>
jpictl: refactor dns command initialization c578990f8c 
Signed-off-by: Alejandro Mery <amery@jpi.io>
jpictl: introduce jpictl dns show command 440dcde50a 
to list dns entries

Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-10-24 01:16:49 +02:00
karasz requested changes 2023-10-24 11:51:12 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

please update the darvaza resolver version, v0.5.4 i sincompatible with core v0.10.0 as core v0.10.0 does not have Wrapf function anymore.

please update the darvaza resolver version, v0.5.4 i sincompatible with core v0.10.0 as core v0.10.0 does not have Wrapf function anymore.
👍 1
amery added 1 commit 2023-10-24 13:02:03 +02:00
chore: update darvaza.org/resolver to support the darvaza.org/core update 66178923a3 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-10-24 13:03:06 +02:00
karasz approved these changes 2023-10-24 15:18:41 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTM now, thank you.

LGTM now, thank you.
🚀 1
amery merged commit 134606207d into main 2023-10-24 15:54:20 +02:00
amery deleted branch pr-amery-dns-show 2023-10-24 15:54:23 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#27
Delete Branch "pr-amery-dns-show"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?