amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

zone.ScanOptions, custom resolver and prevent unnecessary DNS calls #5

Merged
amery merged 5 commits from pr-amery-scan_options into main 2023-08-28 18:10:40 +02:00
Conversation 2 Commits 5 Files Changed 8
+137 -55
amery commented 2023-08-28 17:50:22 +02:00
Owner
Copy Link
Copy Source

performance motivated but useful on the long run anyway

$ time jpictl env > /dev/null

real    0m0.021s
user    0m0.012s
sys     0m0.012s
$ time jpictl dump > /dev/null

real    0m0.283s
user    0m0.024s
sys     0m0.027s
$
performance motivated but useful on the long run anyway ``` $ time jpictl env > /dev/null real 0m0.021s user 0m0.012s sys 0m0.012s $ time jpictl dump > /dev/null real 0m0.283s user 0m0.024s sys 0m0.027s $ ```
amery added 5 commits 2023-08-28 17:50:23 +02:00
zones: introduce ScanOption/ScanOptions for New()/NewFS() 9af88f6593 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: WithLookuper()/WithResolver() 216bf5aa29 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: add ResolvePublicAddresses() ScanOption to prevent early LookupIP calls 0989dec5e8 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: export Machine.LookupNetIP() and Machine.UpdatePublicAddresses() 94daf5ad59 
Signed-off-by: Alejandro Mery <amery@jpi.io>
jpictl: only load Machine.PublicAddresses for jpictl dump 6e46d23b45 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-08-28 17:50:28 +02:00
karasz approved these changes 2023-08-28 18:05:57 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTM

LGTM
🚀 1
amery merged commit 1a03404a07 into main 2023-08-28 18:10:40 +02:00
amery deleted branch pr-amery-scan_options 2023-08-28 18:10:45 +02:00
amery commented 2023-08-28 18:14:58 +02:00
Author
Owner
Copy Link
Copy Source

v0.4.16 tagged

`v0.4.16` tagged
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#5
Delete Branch "pr-amery-scan_options"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?