zone.ScanOptions, custom resolver and prevent unnecessary DNS calls #5

Merged

amery merged 5 commits from pr-amery-scan_options into main 1 year ago

amery commented 1 year ago

Owner

performance motivated but useful on the long run anyway

$ time jpictl env > /dev/null

real    0m0.021s
user    0m0.012s
sys     0m0.012s
$ time jpictl dump > /dev/null

real    0m0.283s
user    0m0.024s
sys     0m0.027s
$

amery added 5 commits 1 year ago

9af88f6593 zones: introduce ScanOption/ScanOptions for New()/NewFS()

Signed-off-by: Alejandro Mery <amery@jpi.io>

216bf5aa29 zones: WithLookuper()/WithResolver()

Signed-off-by: Alejandro Mery <amery@jpi.io>

0989dec5e8 zones: add ResolvePublicAddresses() ScanOption to prevent early LookupIP calls

Signed-off-by: Alejandro Mery <amery@jpi.io>

94daf5ad59 zones: export Machine.LookupNetIP() and Machine.UpdatePublicAddresses()

Signed-off-by: Alejandro Mery <amery@jpi.io>

6e46d23b45 jpictl: only load Machine.PublicAddresses for `jpictl dump`

Signed-off-by: Alejandro Mery <amery@jpi.io>

amery requested review from karasz 1 year ago

karasz approved these changes 1 year ago

karasz left a comment

Owner

LGTM

🚀 1

amery merged commit 1a03404a07 into main 1 year ago

amery referenced this issue from a commit 1 year ago

Merge pull request 'zone.ScanOptions, custom resolver and prevent unnecessary DNS calls' (#5)

amery deleted branch pr-amery-scan_options 1 year ago

amery commented 1 year ago

Poster

Owner

v0.4.16 tagged

Reviewers

karasz approved these changes 1 year ago

The pull request has been merged as 1a03404a07.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.