amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

zones: Env: allow multiple gateways and drop unused ZONE{zoneID}_IP #4

Merged
amery merged 3 commits from pr-amery-env into main 2023-08-28 18:09:00 +02:00
Conversation 3 Commits 3 Files Changed 1
+39 -44
amery commented 2023-08-28 16:54:03 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 3 commits 2023-08-28 16:54:04 +02:00
zones: Env: drop unused ZONE{zoneID}_IP af2d836000 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: Env: minor tidy up 0a3e63e1a2 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: Env: allow multiple gateways on a Zone 6bf897f681 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-08-28 16:54:15 +02:00
karasz reviewed 2023-08-28 17:54:46 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

please see comment

please see comment
pkg/zones/env.go Outdated
@@ -62,2 +67,2 @@
if fn != nil {
value = fn(m)
if n := len(value); n > 0 {
ss := make([]string, len(value))
karasz commented 2023-08-28 17:54:30 +02:00
Owner
Copy Link
Copy Source

I would make it like:

if n := len(value); n > 0 {
	var buffer bytes.Buffer
    for i, v := range value {
    	buffer.WriteString(fmt.Sprintf("%v", v))
    }
}
I would make it like: ```go if n := len(value); n > 0 { var buffer bytes.Buffer for i, v := range value { buffer.WriteString(fmt.Sprintf("%v", v)) } } ```
👍 1
amery commented 2023-08-28 18:00:21 +02:00
Author
Owner
Copy Link
Copy Source

so buffered instead of joined. agreed

so buffered instead of joined. agreed
amery commented 2023-08-28 18:07:46 +02:00
Author
Owner
Copy Link
Copy Source

slightly different to handle the space delimiters, but commit amended to use a bytes.Buffer instead of strings.Join @karasz

slightly different to handle the space delimiters, but commit amended to use a `bytes.Buffer` instead of `strings.Join` @karasz
amery marked this conversation as resolved
amery force-pushed pr-amery-env from 6bf897f681 to 71a1d1a7c2 2023-08-28 18:06:37 +02:00 Compare
karasz approved these changes 2023-08-28 18:07:55 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTMN

LGTMN
👍 1
amery merged commit d2f0a0744b into main 2023-08-28 18:09:00 +02:00
amery deleted branch pr-amery-env 2023-08-28 18:09:26 +02:00
amery commented 2023-08-28 18:10:03 +02:00
Author
Owner
Copy Link
Copy Source

v0.4.15 tagged

`v0.4.15` tagged
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#4
Delete Branch "pr-amery-env"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?