zones: Env: allow multiple gateways and drop unused ZONE{zoneID}_IP #4

Merged
amery merged 3 commits from pr-amery-env into main 2023-08-28 18:09:00 +02:00
Owner
No description provided.
amery added 3 commits 2023-08-28 16:54:04 +02:00
Signed-off-by: Alejandro Mery <amery@jpi.io>
Signed-off-by: Alejandro Mery <amery@jpi.io>
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-08-28 16:54:15 +02:00
karasz reviewed 2023-08-28 17:54:46 +02:00
karasz left a comment
Owner

please see comment

please see comment
pkg/zones/env.go Outdated
@@ -62,2 +67,2 @@
if fn != nil {
value = fn(m)
if n := len(value); n > 0 {
ss := make([]string, len(value))
Owner

I would make it like:

if n := len(value); n > 0 {
	var buffer bytes.Buffer
    for i, v := range value {
    	buffer.WriteString(fmt.Sprintf("%v", v))
    }
}

I would make it like: ```go if n := len(value); n > 0 { var buffer bytes.Buffer for i, v := range value { buffer.WriteString(fmt.Sprintf("%v", v)) } } ```
Author
Owner

so buffered instead of joined. agreed

so buffered instead of joined. agreed
Author
Owner

slightly different to handle the space delimiters, but commit amended to use a bytes.Buffer instead of strings.Join @karasz

slightly different to handle the space delimiters, but commit amended to use a `bytes.Buffer` instead of `strings.Join` @karasz
amery marked this conversation as resolved
amery force-pushed pr-amery-env from 6bf897f681 to 71a1d1a7c2 2023-08-28 18:06:37 +02:00 Compare
karasz approved these changes 2023-08-28 18:07:55 +02:00
karasz left a comment
Owner

LGTMN

LGTMN
amery merged commit d2f0a0744b into main 2023-08-28 18:09:00 +02:00
amery deleted branch pr-amery-env 2023-08-28 18:09:26 +02:00
Author
Owner

v0.4.15 tagged

`v0.4.15` tagged
Sign in to join this conversation.
No Reviewers
No Label
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#4