amery
/
jpictl
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Labels Milestones

zones: Env: allow multiple gateways and drop unused `ZONE{zoneID}_IP` #4

Merged
amery merged 3 commits from pr-amery-env into main 1 year ago
Conversation 1 Commits 3 Files Changed 1
amery commented 1 year ago
Owner
There is no content yet.
amery added 3 commits 1 year ago
af2d836000 zones: Env: drop unused ZONE{zoneID}_IP
0a3e63e1a2 zones: Env: minor tidy up
6bf897f681 zones: Env: allow multiple gateways on a Zone
amery requested review from karasz 1 year ago
karasz reviewed 1 year ago
karasz left a comment
Owner

please see comment

please see comment
pkg/zones/env.go Outdated
if fn != nil {
value = fn(m)
if n := len(value); n > 0 {
ss := make([]string, len(value))
karasz commented 1 year ago
Owner

I would make it like:

if n := len(value); n > 0 {
	var buffer bytes.Buffer
    for i, v := range value {
    	buffer.WriteString(fmt.Sprintf("%v", v))
    }
}
I would make it like: ```go if n := len(value); n > 0 { var buffer bytes.Buffer for i, v := range value { buffer.WriteString(fmt.Sprintf("%v", v)) } } ```
👍 1
amery commented 1 year ago
Poster
Owner

so buffered instead of joined. agreed

so buffered instead of joined. agreed
amery commented 1 year ago
Poster
Owner

slightly different to handle the space delimiters, but commit amended to use a bytes.Buffer instead of strings.Join @karasz

slightly different to handle the space delimiters, but commit amended to use a `bytes.Buffer` instead of `strings.Join` @karasz
amery marked this conversation as resolved
amery force-pushed pr-amery-env from 6bf897f681 to 71a1d1a7c2 1 year ago
karasz approved these changes 1 year ago
karasz left a comment
Owner

LGTMN

LGTMN
👍 1
amery merged commit d2f0a0744b into main 1 year ago
amery deleted branch pr-amery-env 1 year ago
amery commented 1 year ago
Poster
Owner

v0.4.15 tagged

`v0.4.15` tagged

Reviewers

karasz approved these changes 1 year ago
The pull request has been merged as d2f0a0744b.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
karasz
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pr-amery-env'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes