amery
/
jpictl
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Labels Milestones

cluster: introduce Region.Cluser and m/{region}/k8s_token to store a cluster's token #42

Merged
karasz merged 3 commits from pr-amery-k8s_token into main 8 months ago
Conversation 2 Commits 3 Files Changed 2
amery commented 8 months ago
Owner

having this field distinguishes functional regions from primary regions. primary regions determine the kubernetes cluster while functional regions only DNS entrypoints

having this field distinguishes functional regions from primary regions. primary regions determine the kubernetes cluster while functional regions only DNS entrypoints
amery added 2 commits 8 months ago
d51275fb1e cluster: extend usage of the ZoneRegionsFileName constant
3a19922b34 cluster: introduce Region.Cluster and m/{region}/k8s_token
amery requested review from karasz 8 months ago
amery added 1 commit 8 months ago
464c968381 cluster: introduce Region.Cluster and m/{region}/k8s_token
amery commented 8 months ago
Poster
Owner

reduced Zone.loadClusterToken complexity

reduced `Zone.loadClusterToken` complexity
amery added 1 commit 8 months ago
amery added 1 commit 8 months ago
karasz requested changes 8 months ago
pkg/cluster/cluster_scan.go Outdated
return err
}
// first non-empty line
karasz commented 8 months ago
Owner

What happens if the token file has no non-empty lines?

What happens if the token file has no non-empty lines?
amery commented 8 months ago
Poster
Owner

it's marked as cluster but without token (yet)

my intention was to generate the token when installing the first member of such cluster

it's marked as cluster but without token (yet) my intention was to generate the token when installing the first member of such cluster
karasz marked this conversation as resolved
karasz approved these changes 8 months ago
karasz left a comment
Owner

+1

+1
amery added 3 commits 8 months ago
7125e28b74 cluster: extend usage of the ZoneRegionsFileName constant
d3bbe6d270 cluster: introduce Region.Cluster and m/{region}/k8s_token
amery commented 8 months ago
Poster
Owner

rebased

rebased
karasz merged commit 3a2a20a611 into main 8 months ago
karasz deleted branch pr-amery-k8s_token 8 months ago

Reviewers

karasz approved these changes 8 months ago
The pull request has been merged as 3a2a20a611.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
karasz
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pr-amery-k8s_token'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes