amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

cluster: introduce Region.Cluser and m/{region}/k8s_token to store a cluster's token #42

Merged
karasz merged 3 commits from pr-amery-k8s_token into main 2024-03-19 17:44:48 +01:00
Conversation 4 Commits 3 Files Changed 2
+113 -14
amery commented 2024-03-02 22:01:52 +01:00
Owner
Copy Link
Copy Source

having this field distinguishes functional regions from primary regions. primary regions determine the kubernetes cluster while functional regions only DNS entrypoints

having this field distinguishes functional regions from primary regions. primary regions determine the kubernetes cluster while functional regions only DNS entrypoints
amery added 2 commits 2024-03-02 22:01:53 +01:00
cluster: extend usage of the ZoneRegionsFileName constant d51275fb1e 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: introduce Region.Cluster and m/{region}/k8s_token 3a19922b34 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2024-03-02 22:01:59 +01:00
amery added 1 commit 2024-03-02 22:30:46 +01:00
cluster: introduce Region.Cluster and m/{region}/k8s_token 464c968381 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery commented 2024-03-02 22:31:12 +01:00
Author
Owner
Copy Link
Copy Source

reduced Zone.loadClusterToken complexity

reduced `Zone.loadClusterToken` complexity
amery added 1 commit 2024-03-02 22:35:10 +01:00
cluster: remove k8s_token files from zones on write if found 3efe9c1d20 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery added 1 commit 2024-03-02 23:09:33 +01:00
cluster: remove k8s_token files from zones on write if found 299556544d 
Signed-off-by: Alejandro Mery <amery@jpi.io>
karasz requested changes 2024-03-05 17:13:48 +01:00
pkg/cluster/cluster_scan.go Outdated
@@ -221,0 +234,4 @@
return err
}
// first non-empty line
karasz commented 2024-03-05 17:13:29 +01:00
Owner
Copy Link
Copy Source

What happens if the token file has no non-empty lines?

What happens if the token file has no non-empty lines?
amery commented 2024-03-19 17:28:47 +01:00
Author
Owner
Copy Link
Copy Source

it's marked as cluster but without token (yet)

my intention was to generate the token when installing the first member of such cluster

it's marked as cluster but without token (yet) my intention was to generate the token when installing the first member of such cluster
karasz marked this conversation as resolved
karasz approved these changes 2024-03-19 17:38:36 +01:00
karasz left a comment
Owner
Copy Link
Copy Source

+1

+1
amery added 3 commits 2024-03-19 17:43:02 +01:00
cluster: extend usage of the ZoneRegionsFileName constant 7125e28b74 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: introduce Region.Cluster and m/{region}/k8s_token d3bbe6d270 
Signed-off-by: Alejandro Mery <amery@jpi.io>
cluster: remove k8s_token files from zones on write if found 019143820f 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery commented 2024-03-19 17:43:45 +01:00
Author
Owner
Copy Link
Copy Source

rebased

rebased
karasz merged commit 3a2a20a611 into main 2024-03-19 17:44:48 +01:00
karasz deleted branch pr-amery-k8s_token 2024-03-19 17:47:11 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#42
Delete Branch "pr-amery-k8s_token"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?