asciigoat/core
1
Fork 0
Code Issues Pull Requests Projects Releases Activity

lexer: rename runes.Reader to lexer.Reader and implement UnreadRune() and PeekRune() #4

Merged
amery merged 3 commits from pr-amery-reader into main 2023-08-29 15:23:15 +02:00
Conversation 2 Commits 3 Files Changed 3
+46 -4
amery commented 2023-08-29 04:05:05 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 3 commits 2023-08-29 04:05:06 +02:00
lexer: runes.Reader renamed to lexer.Reader 7230a74f49 
Signed-off-by: Alejandro Mery <amery@jpi.io>
lexer: fix ReadRune() to actually move the cursor edcba80baa 
Signed-off-by: Alejandro Mery <amery@jpi.io>
lexer: Implement Reader.UnreadRune() and Reader.PeekRune() 6cca2996ca 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-08-29 04:05:10 +02:00
karasz approved these changes 2023-08-29 09:57:22 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTM

LGTM
amery merged commit f79e2bee9e into main 2023-08-29 15:23:15 +02:00
amery commented 2023-08-29 15:24:15 +02:00
Author
Owner
Copy Link
Copy Source

v0.3.1 tagged

`v0.3.1` tagged
amery deleted branch pr-amery-reader 2023-08-29 15:24:19 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amery (Alejandro Mery) karasz (Nagy Károly Gábriel)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: asciigoat/core#4
Delete Branch "pr-amery-reader"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?