Labels Milestones

lexer: rename runes.Reader to lexer.Reader and implement UnreadRune() and PeekRune() #4

Merged

amery merged 3 commits from pr-amery-reader into main 1 year ago

Conversation 1 Commits 3 Files Changed 3

amery commented 1 year ago

Owner

There is no content yet.

amery added 3 commits 1 year ago

7230a74f49 lexer: runes.Reader renamed to lexer.Reader ...

Signed-off-by: Alejandro Mery <amery@jpi.io>

edcba80baa lexer: fix ReadRune() to actually move the cursor ...

Signed-off-by: Alejandro Mery <amery@jpi.io>

6cca2996ca lexer: Implement Reader.UnreadRune() and Reader.PeekRune() ...

Signed-off-by: Alejandro Mery <amery@jpi.io>

amery requested review from karasz 1 year ago

karasz approved these changes 1 year ago

karasz left a comment

Owner

LGTM

LGTM

amery merged commit f79e2bee9e into main 1 year ago

amery referenced this issue from a commit 1 year ago

Merge pull request 'lexer: rename runes.Reader to lexer.Reader and implement UnreadRune() and PeekRune()' (#4)

amery commented 1 year ago

Poster

Owner

v0.3.1 tagged

`v0.3.1` tagged

amery deleted branch pr-amery-reader 1 year ago

Reviewers

karasz approved these changes 1 year ago

The pull request has been merged as f79e2bee9e.

Sign in to join this conversation.

Reviewers

Request review

No reviewers

karasz

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview

Loading…

Cancel

Save

There is no content yet.