asciigoat/core
1
Fork 0
Code Issues Pull Requests Projects Releases Activity

lexer: add Hint to Error, which is expanded as "%s" instead of "%q" #12

Merged
amery merged 2 commits from pr-amery-error into main 2023-09-04 15:15:03 +02:00
Conversation 2 Commits 2 Files Changed 1
+21 -5
amery commented 2023-08-31 18:38:28 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 1 commit 2023-08-31 18:38:29 +02:00
lexer: add Hint to Error, which is expanded as "%s" instead of "%q" eb2e4ef83c 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-08-31 18:38:32 +02:00
amery added 2 commits 2023-08-31 22:12:07 +02:00
lexer: refactor Error.Error()'s prefix generator 4aa6233e4f 
Signed-off-by: Alejandro Mery <amery@jpi.io>
lexer: add Hint to Error, which is expanded as "%s" instead of "%q" 2b5dcec64d 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery commented 2023-08-31 22:14:20 +02:00
Author
Owner
Copy Link
Copy Source

refactored to reduce complexity

refactored to reduce complexity
amery added 2 commits 2023-09-03 18:35:30 +02:00
lexer: refactor Error.Error()'s prefix generator 1d7ee69ab7 
Signed-off-by: Alejandro Mery <amery@jpi.io>
lexer: add Hint to Error, which is expanded as "%s" instead of "%q" ce75299e74 
Signed-off-by: Alejandro Mery <amery@jpi.io>
karasz approved these changes 2023-09-04 10:30:21 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTM

LGTM
amery merged commit 5f81eb0ea5 into main 2023-09-04 15:15:03 +02:00
amery deleted branch pr-amery-error 2023-09-04 15:15:03 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amery (Alejandro Mery) karasz (Nagy Károly Gábriel)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: asciigoat/core#12
Delete Branch "pr-amery-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?