8 Commits

Author SHA1 Message Date
amery 7968b06d7e build-sys: use local darvaza.org/core [DO-NOT-MERGE]
Signed-off-by: Alejandro Mery <amery@jpi.io>
2023-09-04 18:19:54 +00:00
amery 8b0bb69809 build-sys: use local asciigoat.org/core [DO-NOT-MERGE]
Signed-off-by: Alejandro Mery <amery@jpi.io>
2023-09-04 18:19:54 +00:00
amery c9f75bf74a vscode: add Subname to the dictionary
Signed-off-by: Alejandro Mery <amery@jpi.io>
2023-09-04 18:19:54 +00:00
amery 4336ced6a8 vscode: add unescapes to the dictionary
Signed-off-by: Alejandro Mery <amery@jpi.io>
2023-09-04 18:19:54 +00:00
amery 67a8fb1387 vscode: add asciigoat to the dictionary
Signed-off-by: Alejandro Mery <amery@jpi.io>
2023-09-04 18:19:54 +00:00
amery fa8eec7aa1 Merge branch 'pr-amery-parser-quoted' into next-amery 2023-09-04 18:19:45 +00:00
amery beb7c29fed parser: introduce SplitCommaArray to splits comma separated strings
removing whitespace and respecting quoted literals.

Signed-off-by: Alejandro Mery <amery@jpi.io>
2023-09-04 18:17:03 +00:00
amery b16aa02140 parser: Unquoted(), AcceptQuotedString()
TODO: reduce quoted strings with escaped characters

Signed-off-by: Alejandro Mery <amery@jpi.io>
2023-09-04 18:14:39 +00:00
2 changed files with 21 additions and 71 deletions
-12
View File
@@ -48,15 +48,3 @@ func newErrIncomplete(p *TextParser, hint string) *lexer.Error {
return NewError(pos, s, hint, fs.ErrInvalid) return NewError(pos, s, hint, fs.ErrInvalid)
} }
// NewErrInvalidEscapeSequence returns a [lexer.Error] indicating
// the specified sequence, at the end of the accepted buffer,
// is invalid
func NewErrInvalidEscapeSequence(p *TextParser, seq string) *lexer.Error {
pos, s := p.Position(), p.String()
s = s[:len(s)-len(seq)]
pos.Add(GetPositionalLength(s))
return NewError(pos, seq, "invalid escape character", fs.ErrInvalid)
}
+21 -59
View File
@@ -33,34 +33,22 @@ func (p *TextParser) AcceptQuotedString() (string, bool, error) {
} }
func lexQuotedString(p *TextParser) (string, *lexer.Error) { func lexQuotedString(p *TextParser) (string, *lexer.Error) {
s, ok, err := lexQuotedStringNoEscape(p)
switch {
case err != nil:
return "", err
case ok:
return s, nil
default:
// escape character detected
return lexQuotedStringEscaped(p)
}
}
func lexQuotedStringNoEscape(p *TextParser) (string, bool, *lexer.Error) {
for { for {
r, _, err := p.ReadRune() r, _, err := p.ReadRune()
switch { switch {
case err != nil: case err != nil:
// incomplete // incomplete
return "", false, NewErrIncompleteQuotedString(p) return "", NewErrIncompleteQuotedString(p)
case r == RuneQuotes: case r == RuneQuotes:
// end, just remove the quotes // end, remove quotes and process escaped characters
s := p.String() return lexReturnUnescapedQuotedString(p)
l := len(s)
return s[1 : l-1], true, nil
case r == RuneEscape: case r == RuneEscape:
// things just got complicated... // escaped, take another
p.UnreadRune() _, _, err := p.ReadRune()
return "", false, nil if err != nil {
// incomplete
return "", NewErrIncompleteQuotedString(p)
}
case IsNewLine(r): case IsNewLine(r):
// new lines within quoted values are acceptable // new lines within quoted values are acceptable
p.UnreadRune() p.UnreadRune()
@@ -71,48 +59,22 @@ func lexQuotedStringNoEscape(p *TextParser) (string, bool, *lexer.Error) {
} }
} }
// Unquoted removes quotes the content and unescapes the content func lexReturnUnescapedQuotedString(p *TextParser) (string, *lexer.Error) {
func lexQuotedStringEscaped(p *TextParser) (string, *lexer.Error) { // remove quotes
var result strings.Builder s := p.String()
l := len(s)
s = s[1 : l-1]
// append what was accepted before the escape character if strings.ContainsRune(s, RuneEscape) {
_, _ = result.WriteString(p.String()[1:]) // TODO: implement unescaping
err := NewError(p.Position(), s, "escaped characters", lexer.ErrNotImplemented)
for { return "", err
r, _, err := p.ReadRune()
switch {
case err != nil:
// incomplete quoted
return "", NewErrIncompleteQuotedString(p)
case r == RuneQuotes:
// end
return result.String(), nil
case r == RuneEscape:
// escaped
r2, _, err := p.ReadRune()
switch {
case err != nil:
// incomplete escaped
return "", NewErrIncompleteEscaped(p)
case IsNewLine(r2):
// escaped new line, skip
p.UnreadRune()
p.AcceptNewLine()
default:
// TODO: check valid escape character and
// append to result
s := string([]rune{r, r2})
err := NewErrInvalidEscapeSequence(p, s)
return "", err
}
default:
// normal, append to result
_, _ = result.WriteRune(r)
}
} }
return s, nil
} }
// Unquoted removes quotes and unescapes the content // Unquoted removes quotes the content and unescapes the content
func Unquoted(s string) (string, error) { func Unquoted(s string) (string, error) {
var p TextParser var p TextParser
if s == "" { if s == "" {