chore: update asciigoat.org/core

Signed-off-by: Alejandro Mery <amery@jpi.io>

README.md

@@ -16,7 +16,6 @@ of stricter parsers of similar form.
 
 [godoc-lexer]: https://pkg.go.dev/asciigoat.org/core/lexer
 [godoc-parser-parser]: https://pkg.go.dev/asciigoat.org/ini/parser#Parser
-[godoc-basic-parser]: https://pkg.go.dev/asciigoat.org/ini/basic#Decode
 
 [wikipedia-dosini]: https://en.wikipedia.org/wiki/INI_file
 
@@ -26,16 +25,16 @@ of stricter parsers of similar form.
 [`asciigoat`'s lexer][godoc-lexer] to process an `INI`-style document
 emiting tokens and errors via callbacks.
 
-## Basic Parser
-
-[`basic.Decode()`][godoc-basic-parser] provies a one-shot decoder
-that returns a structured document for you to post-process.
-
-To allow for correct handling of repetition of section and field names downstream, it uses arrays instead of maps, and makes almost no judgment
-about what section or field names are acceptable.
-
 ## Other Implementations
 
+Other implementations exist, and they are mature and feature-rich, but they
+are highly opinionated about what's a valid file. Built around maps they don't
+allow repeating names and constraint what characters can be used.
+
+These are great when you can adapt, or already agree, to their conditions but
+that's not always the case when you are parsing configuration files from
+other applications and that's what [asciigoat.org/ini][godoc] attempts to solve.
+
 * [gcfg](https://pkg.go.dev/gopkg.in/gcfg.v1)
 * [unknwon's go-ini](https://github.com/go-ini/ini)
 * [wlevene's GoINI](https://github.com/wlevene/ini)

basic/basic.go

@@ -1,2 +0,0 @@
-// Package basic provides a basic representation of dosini-style documents
-package basic

basic/decoder.go

@@ -1,73 +0,0 @@
-package basic
-
-import (
-	"bytes"
-	"io"
-	"io/fs"
-	"log"
-	"strings"
-
-	"asciigoat.org/core/lexer"
-	"asciigoat.org/ini/parser"
-)
-
-type token struct {
-	pos   lexer.Position
-	typ   parser.TokenType
-	value string
-}
-
-type decoder struct {
-	p   *parser.Parser
-	out *Document
-
-	queue      []token
-	curSection *Section
-	curField   *Field
-}
-
-func (dec *decoder) OnToken(pos lexer.Position, typ parser.TokenType, value string) error {
-	tok := token{pos, typ, value}
-
-	log.Printf("%s[%v]: %s %s: %q", "decoder", len(dec.queue), pos, typ, value)
-
-	dec.queue = append(dec.queue, tok)
-
-	return nil
-}
-
-func (*decoder) OnError(pos lexer.Position, hint string, err error) error {
-	log.Printf("%s: %s %s: %s: %v", "decoder", pos, "error", hint, err)
-	return err
-}
-
-// Decode ...
-func Decode(r io.Reader) (*Document, error) {
-	var out Document
-
-	if r == nil {
-		return nil, fs.ErrNotExist
-	}
-
-	// parser
-	p := parser.NewParser(r)
-	// decoder
-	dec := decoder{p: p, out: &out}
-	// glue
-	p.OnToken = dec.OnToken
-	p.OnError = dec.OnError
-
-	// Go!
-	err := p.Run()
-	return &out, err
-}
-
-// DecodeBytes ...
-func DecodeBytes(b []byte) (*Document, error) {
-	return Decode(bytes.NewReader(b))
-}
-
-// DecodeString ...
-func DecodeString(s string) (*Document, error) {
-	return Decode(strings.NewReader(s))
-}

basic/types.go

@@ -1,23 +0,0 @@
-package basic
-
-// Document ...
-type Document struct {
-	Global []Field
-
-	Sections []Section
-}
-
-// Section ...
-type Section struct {
-	Name   string
-	Key    string
-	HadKey bool
-
-	Fields []Field
-}
-
-// Field ...
-type Field struct {
-	Key   string
-	Value string
-}

decoder.go

@@ -1,49 +0,0 @@
-package ini
-
-import (
-	"bytes"
-	"io"
-	"strings"
-
-	"asciigoat.org/core"
-	"asciigoat.org/ini/parser"
-)
-
-// Decoder ...
-type Decoder struct {
-	io.Closer
-
-	p *parser.Parser
-}
-
-// Decode ...
-func (dec *Decoder) Decode() error {
-	defer dec.Close()
-
-	return dec.p.Run()
-}
-
-// NewDecoder creates a Decoder over the provided [io.Reader]
-func NewDecoder(r io.Reader) *Decoder {
-	rc := core.NewReadCloser(r)
-	switch {
-	case rc == nil:
-		return nil
-	default:
-		dec := &Decoder{
-			p:      parser.NewParser(rc),
-			Closer: rc,
-		}
-		return dec
-	}
-}
-
-// NewDecoderBytes creates a Decoder over a provided bytes array
-func NewDecoderBytes(b []byte) *Decoder {
-	return NewDecoder(bytes.NewReader(b))
-}
-
-// NewDecoderString creates a Decoder over a provided string of data
-func NewDecoderString(s string) *Decoder {
-	return NewDecoder(strings.NewReader(s))
-}

go.mod

@@ -2,8 +2,6 @@ module asciigoat.org/ini
 
 go 1.19
 
-replace asciigoat.org/core => ../core
-
 require (
 	asciigoat.org/core v0.3.7
 	github.com/mgechev/revive v1.3.3

go.sum

@@ -1,3 +1,5 @@
+asciigoat.org/core v0.3.7 h1:tMasdvZgsMJJMVsZVfXXB5lqq82pFiCsyEmOEmcmAfI=
+asciigoat.org/core v0.3.7/go.mod h1:tXj+JUutxRbcO40ZQRuUVaZ4rnYz1kAZ0nblisV8u74=
 github.com/BurntSushi/toml v1.3.2 h1:o7IhLm0Msx3BaB+n3Ag7L8EVlByGnpq14C4YWiu/gL8=
 github.com/BurntSushi/toml v1.3.2/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ=
 github.com/chavacava/garif v0.0.0-20230608123814-4bd63c2919ab h1:5JxePczlyGAtj6R1MUEFZ/UFud6FfsOejq7xLC2ZIb0=

unmarshal.go

@@ -1,15 +0,0 @@
-package ini
-
-import "io"
-
-// ReadInto ...
-func ReadInto(v any, r io.Reader) error {
-	dec := NewDecoder(r)
-
-	return dec.Unmarshal(v)
-}
-
-// Unmarshal ...
-func (dec *Decoder) Unmarshal(any) error {
-	return dec.p.Run()
-}