asciigoat/ini
2
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

parser: introduce TextParser and refactor Parser #7

Merged
amery merged 5 commits from pr-amery-textparser into main 2023-09-04 16:17:05 +02:00
Conversation 4 Commits 5 Files Changed 7
+182 -76
amery commented 2023-09-03 19:02:11 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 3 commits 2023-09-03 19:02:12 +02:00
parser: introduce generic-ish TextParser ecff6f6016 
Signed-off-by: Alejandro Mery <amery@jpi.io>
parser.TextParser: AcceptNewLine() and AcceptRune() e34e8eda0a 
Signed-off-by: Alejandro Mery <amery@jpi.io>
parser.Parser: refactor using TextParser 01cd4139bd 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-09-03 19:03:13 +02:00
amery added 2 commits 2023-09-03 19:44:04 +02:00
parser: introduce GetPositionalLength() 8cc75da138 
Signed-off-by: Alejandro Mery <amery@jpi.io>
parser: use GetPositionalLength() on TextParser.Discard() and TextParser.Emit() baf2a97379 
Signed-off-by: Alejandro Mery <amery@jpi.io>
karasz requested changes 2023-09-04 10:40:37 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

this requires asciigoat 0.3.8, but mod file is not updated to reflect that

this requires asciigoat 0.3.8, but mod file is not updated to reflect that
amery commented 2023-09-04 15:30:31 +02:00
Author
Owner
Copy Link
Copy Source

this requires asciigoat 0.3.8, but mod file is not updated to reflect that

weird. the branch builds for me as-is. maybe go.work is messing things up

> this requires asciigoat 0.3.8, but mod file is not updated to reflect that weird. the branch builds for me as-is. maybe go.work is messing things up
amery added 1 commit 2023-09-04 15:34:23 +02:00
parser: use GetPositionalLength() on TextParser.Discard() and TextParser.Emit() 30a86e170b 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery commented 2023-09-04 15:34:26 +02:00
Author
Owner
Copy Link
Copy Source

TextParser.Discard()/Text.Emit() commit amended to required asciigoat 0.3.9 for lexer.Position.Add().

TextParser.Discard()/Text.Emit() commit amended to required asciigoat 0.3.9 for lexer.Position.Add().
amery requested review from karasz 2023-09-04 15:34:41 +02:00
karasz approved these changes 2023-09-04 15:42:16 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTMN

LGTMN
🎉 1
amery merged commit 314c004efd into main 2023-09-04 16:17:05 +02:00
amery deleted branch pr-amery-textparser 2023-09-04 16:17:05 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amery (Alejandro Mery) karasz (Nagy Károly Gábriel)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: asciigoat/ini#7
Delete Branch "pr-amery-textparser"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?