asciigoat
/
ini
2
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity
Labels Milestones

parser: introduce TextParser and refactor Parser #7

Merged
amery merged 5 commits from pr-amery-textparser into main 2 years ago
Conversation 2 Commits 5 Files Changed 7
amery commented 2 years ago
Owner
There is no content yet.
amery added 3 commits 2 years ago
amery requested review from karasz 2 years ago
amery added 2 commits 2 years ago
karasz requested changes 2 years ago
karasz left a comment
Owner

this requires asciigoat 0.3.8, but mod file is not updated to reflect that

this requires asciigoat 0.3.8, but mod file is not updated to reflect that
amery commented 2 years ago
Poster
Owner

this requires asciigoat 0.3.8, but mod file is not updated to reflect that

weird. the branch builds for me as-is. maybe go.work is messing things up

> this requires asciigoat 0.3.8, but mod file is not updated to reflect that weird. the branch builds for me as-is. maybe go.work is messing things up
amery added 1 commit 2 years ago
amery commented 2 years ago
Poster
Owner

TextParser.Discard()/Text.Emit() commit amended to required asciigoat 0.3.9 for lexer.Position.Add().

TextParser.Discard()/Text.Emit() commit amended to required asciigoat 0.3.9 for lexer.Position.Add().
amery requested review from karasz 2 years ago
karasz approved these changes 2 years ago
karasz left a comment
Owner

LGTMN

LGTMN
🎉 1
amery merged commit 314c004efd into main 2 years ago
amery deleted branch pr-amery-textparser 2 years ago

Reviewers

karasz approved these changes 2 years ago
The pull request has been merged as 314c004efd.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
karasz
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pr-amery-textparser'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes