asciigoat/core
1
Fork 0
Code Issues Pull Requests Projects Releases Activity

lexer: Reader.Accept(), AcceptAll(), and StateFn #5

Merged
amery merged 3 commits from pr-amery-lexer into main 2023-08-30 19:02:16 +02:00
Conversation 4 Commits 3 Files Changed 2
+64
amery commented 2023-08-29 15:30:05 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 2 commits 2023-08-29 15:30:05 +02:00
lexer: introduce Reader.Accept()/AcceptAll() d83b128c30 
Signed-off-by: Alejandro Mery <amery@jpi.io>
lexer: introduce StateFn and the basic state machine loop 15938090f6 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-08-29 15:30:10 +02:00
karasz requested changes 2023-08-29 16:00:41 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

Can you please rewrite the Run function, your usage of fn is confusing, also err being just declared gets the default value on first iteration which should be nil hence breaking the for loop

Can you please rewrite the Run function, your usage of `fn` is confusing, also `err` being just declared gets the default value on first iteration which should be `nil` hence breaking the for loop
👍 1
amery added 1 commit 2023-08-29 17:12:26 +02:00
lexer: introduce StateFn and the basic state machine loop 1d62857e14 
v2: make the error break more explicit

Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-08-29 17:12:37 +02:00
amery commented 2023-08-29 17:12:53 +02:00
Author
Owner
Copy Link
Copy Source

@karasz amended

@karasz amended
amery added 1 commit 2023-08-30 02:51:45 +02:00
lexer: extend Run() to treat io.EOF as non-error termination 05d504346e 
Signed-off-by: Alejandro Mery <amery@jpi.io>
karasz approved these changes 2023-08-30 09:12:27 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

OK

OK
🚀 1
amery merged commit f8f6ff9e11 into main 2023-08-30 19:02:16 +02:00
amery deleted branch pr-amery-lexer 2023-08-30 19:02:48 +02:00
amery commented 2023-08-30 19:46:20 +02:00
Author
Owner
Copy Link
Copy Source

v0.3.5 tagged

`v0.3.5` tagged
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amery (Alejandro Mery) karasz (Nagy Károly Gábriel)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: asciigoat/core#5
Delete Branch "pr-amery-lexer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?