lexer: Reader.Accept(), AcceptAll(), and StateFn #5

Merged

amery merged 3 commits from pr-amery-lexer into main 1 year ago

amery commented 1 year ago

Owner

There is no content yet.

amery added 2 commits 1 year ago

d83b128c30 lexer: introduce Reader.Accept()/AcceptAll()

Signed-off-by: Alejandro Mery <amery@jpi.io>

15938090f6 lexer: introduce StateFn and the basic state machine loop

Signed-off-by: Alejandro Mery <amery@jpi.io>

amery requested review from karasz 1 year ago

karasz requested changes 1 year ago

karasz left a comment

Owner

Can you please rewrite the Run function, your usage of fn is confusing, also err being just declared gets the default value on first iteration which should be nil hence breaking the for loop

👍 1

amery added 1 commit 1 year ago

1d62857e14 lexer: introduce StateFn and the basic state machine loop

v2: make the error break more explicit

Signed-off-by: Alejandro Mery <amery@jpi.io>

amery requested review from karasz 1 year ago

amery commented 1 year ago

Poster

Owner

@karasz amended

amery added 1 commit 1 year ago

05d504346e lexer: extend Run() to treat io.EOF as non-error termination

Signed-off-by: Alejandro Mery <amery@jpi.io>

karasz approved these changes 1 year ago

karasz left a comment

Owner

OK

🚀 1

amery merged commit f8f6ff9e11 into main 1 year ago

amery referenced this issue from a commit 1 year ago

Merge pull request 'lexer: Reader.Accept(), AcceptAll(), and StateFn' (#5)

amery deleted branch pr-amery-lexer 1 year ago

amery commented 1 year ago

Poster

Owner

v0.3.5 tagged

Reviewers

karasz approved these changes 1 year ago

The pull request has been merged as f8f6ff9e11.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.