Merge pull request 'basic: introduce basic one-shot INI-style decoder' (#4)

Reviewed-on: #4

basic/basic.go

@@ -1,2 +1,24 @@
 // Package basic provides a basic representation of dosini-style documents
 package basic
+
+// Document represents an INI-style document
+type Document struct {
+	Global []Field
+
+	Sections []Section
+}
+
+// Section represents an INI-style section with optional GIT-style IDs
+type Section struct {
+	Key     string
+	ID      string
+	EmptyID bool
+
+	Fields []Field
+}
+
+// Field represents a key = value entry in an INI-style document
+type Field struct {
+	Key   string
+	Value string
+}

basic/token.go

@@ -50,15 +50,17 @@ func (dec *decoder) execute(typ parser.TokenType) {
 	}
 }
 
-func (dec *decoder) addSection(name, key string, hadKey bool) {
+func (dec *decoder) addSection(key, id string, allowEmptyID bool) {
+	emptyID := allowEmptyID && id == ""
+
 	// index for dec.current
 	n := len(dec.out.Sections)
 
 	// new section
 	dec.out.Sections = append(dec.out.Sections, Section{
-		Name:   name,
-		Key:    key,
-		HadKey: hadKey,
+		Key:     key,
+		ID:      id,
+		EmptyID: emptyID,
 	})
 
 	// pointer to the latest section

basic/types.go

@@ -1,23 +0,0 @@
-package basic
-
-// Document ...
-type Document struct {
-	Global []Field
-
-	Sections []Section
-}
-
-// Section ...
-type Section struct {
-	Name   string
-	Key    string
-	HadKey bool
-
-	Fields []Field
-}
-
-// Field ...
-type Field struct {
-	Key   string
-	Value string
-}

basic/write.go

@@ -0,0 +1,88 @@
+package basic
+
+import (
+	"bytes"
+	"fmt"
+	"io"
+
+	"asciigoat.org/ini/parser"
+)
+
+// WriteNewLine is the new line representation used by [doc.WriteTo]
+const WriteNewLine = "\n"
+
+// AsBuffer returns a INI representation of the document on
+// a memory buffer
+func (doc *Document) AsBuffer(nl string) *bytes.Buffer {
+	var buf bytes.Buffer
+
+	if len(doc.Global) > 0 {
+		_, _ = writeFieldsTo(&buf, doc.Global, nl)
+	}
+
+	for _, sec := range doc.Sections {
+		if buf.Len() > 0 {
+			_, _ = buf.WriteString(nl)
+		}
+
+		_ = writeSectionToBuffer(&buf, &sec, nl)
+	}
+
+	return &buf
+}
+
+func writeFieldsTo(w io.Writer, fields []Field, nl string) (int64, error) {
+	var written int
+	for _, field := range fields {
+		n, err := fmt.Fprintf(w, "%s = %q%s", field.Key, field.Value, nl)
+		switch {
+		case err != nil:
+			return int64(written), err
+		case n > 0:
+			written += n
+		}
+	}
+	return int64(written), nil
+}
+
+func writeSectionToBuffer(w *bytes.Buffer, sec *Section, nl string) int {
+	var written, n int
+
+	_, _ = w.WriteRune(parser.RuneSectionStart)
+	written++
+
+	n, _ = w.WriteString(sec.Key)
+	written += n
+
+	switch {
+	case sec.EmptyID:
+		n, _ = w.WriteString(" \"\"")
+		written += n
+	case sec.ID != "":
+		_, _ = w.WriteRune(' ')
+		n, _ = fmt.Fprintf(w, "%q", sec.ID)
+		written += n + 1
+	}
+
+	_, _ = w.WriteRune(parser.RuneSectionEnd)
+	written++
+
+	n, _ = w.WriteString(nl)
+	written += n
+
+	n64, _ := writeFieldsTo(w, sec.Fields, nl)
+	return written + int(n64)
+}
+
+// WriteTo writes a INI representation of the document
+// onto the provided writer.
+func (doc *Document) WriteTo(w io.Writer) (int64, error) {
+	buf := doc.AsBuffer(WriteNewLine)
+	return buf.WriteTo(w)
+}
+
+// GoString generates a string output for "%s"
+func (doc *Document) String() string {
+	buf := doc.AsBuffer(WriteNewLine)
+	return buf.String()
+}

decoder.go

@@ -1,49 +0,0 @@
-package ini
-
-import (
-	"bytes"
-	"io"
-	"strings"
-
-	"asciigoat.org/core"
-	"asciigoat.org/ini/parser"
-)
-
-// Decoder ...
-type Decoder struct {
-	io.Closer
-
-	p *parser.Parser
-}
-
-// Decode ...
-func (dec *Decoder) Decode() error {
-	defer dec.Close()
-
-	return dec.p.Run()
-}
-
-// NewDecoder creates a Decoder over the provided [io.Reader]
-func NewDecoder(r io.Reader) *Decoder {
-	rc := core.NewReadCloser(r)
-	switch {
-	case rc == nil:
-		return nil
-	default:
-		dec := &Decoder{
-			p:      parser.NewParser(rc),
-			Closer: rc,
-		}
-		return dec
-	}
-}
-
-// NewDecoderBytes creates a Decoder over a provided bytes array
-func NewDecoderBytes(b []byte) *Decoder {
-	return NewDecoder(bytes.NewReader(b))
-}
-
-// NewDecoderString creates a Decoder over a provided string of data
-func NewDecoderString(s string) *Decoder {
-	return NewDecoder(strings.NewReader(s))
-}

go.mod

@@ -2,8 +2,6 @@ module asciigoat.org/ini
 
 go 1.19
 
-replace asciigoat.org/core => ../core
-
 require (
 	asciigoat.org/core v0.3.7
 	github.com/mgechev/revive v1.3.3

go.sum

@@ -1,3 +1,5 @@
+asciigoat.org/core v0.3.7 h1:tMasdvZgsMJJMVsZVfXXB5lqq82pFiCsyEmOEmcmAfI=
+asciigoat.org/core v0.3.7/go.mod h1:tXj+JUutxRbcO40ZQRuUVaZ4rnYz1kAZ0nblisV8u74=
 github.com/BurntSushi/toml v1.3.2 h1:o7IhLm0Msx3BaB+n3Ag7L8EVlByGnpq14C4YWiu/gL8=
 github.com/BurntSushi/toml v1.3.2/go.mod h1:CxXYINrC8qIiEnFrOxCa7Jy5BFHlXnUU2pbicEuybxQ=
 github.com/chavacava/garif v0.0.0-20230608123814-4bd63c2919ab h1:5JxePczlyGAtj6R1MUEFZ/UFud6FfsOejq7xLC2ZIb0=

unmarshal.go

@@ -1,15 +0,0 @@
-package ini
-
-import "io"
-
-// ReadInto ...
-func ReadInto(v any, r io.Reader) error {
-	dec := NewDecoder(r)
-
-	return dec.Unmarshal(v)
-}
-
-// Unmarshal ...
-func (dec *Decoder) Unmarshal(any) error {
-	return dec.p.Run()
-}