m/eu/k8s_token [DO-NOT-MERGE]

Signed-off-by: Alejandro Mery <amery@jpi.io>

pkg/cluster/cluster_scan.go

@@ -4,7 +4,6 @@ import (
 	"io/fs"
 	"path"
 	"sort"
-	"strings"
 
 	"darvaza.org/core"
 )
@@ -226,17 +225,12 @@ func (z *Zone) loadRegions() error {
 }
 
 func (z *Zone) loadClusterToken() error {
-	var token string
-
 	filename := path.Join(z.Name, RegionClusterTokenFileName)
 	lines, err := z.zones.ReadLines(filename)
-	if err != nil {
+	if err == nil {
-		return err
+		var token string
-	}
 
-	// first non-empty line
 		for _, s := range lines {
-		s = strings.TrimSpace(s)
 			if s != "" {
 				token = s
 				break
@@ -247,6 +241,7 @@ func (z *Zone) loadClusterToken() error {
 		if err != nil {
 			err = core.Wrap(err, filename)
 		}
+	}
 
 	return err
 }

pkg/cluster/env.go

@@ -85,29 +85,22 @@ func (m *Env) writeEnvZone(w io.Writer, z *Zone) {
 }
 
 func (m *Env) writeEnvVarInts(w io.Writer, value []int, name string, args ...any) {
+	var s string
+
+	if n := len(value); n > 0 {
 		var buf bytes.Buffer
 
-	for _, v := range value {
+		for i, v := range value {
-		if buf.Len() > 0 {
+			if i != 0 {
 				_, _ = fmt.Fprint(&buf, " ")
 			}
 			_, _ = fmt.Fprintf(&buf, "%v", v)
 		}
 
-	m.writeEnvVar(w, buf.String(), name, args...)
+		s = buf.String()
 	}
 
-func (m *Env) writeEnvVarStrings(w io.Writer, value []string, name string, args ...any) {
+	m.writeEnvVar(w, s, name, args...)
-	var buf bytes.Buffer
-
-	for _, v := range value {
-		if buf.Len() > 0 {
-			_, _ = fmt.Fprint(&buf, " ")
-		}
-		_, _ = fmt.Fprintf(&buf, "%s", v)
-	}
-
-	m.writeEnvVar(w, buf.String(), name, args...)
 }
 
 func (m *Env) writeEnvVar(w io.Writer, value string, name string, args ...any) {

pkg/cluster/regions.go

@@ -8,14 +8,8 @@ import (
 var (
 	_ MachineIterator = (*Region)(nil)
 	_ ZoneIterator    = (*Region)(nil)
-	_ RegionIterator  = (*Cluster)(nil)
 )
 
-// A RegionIterator is a set of Regions we can iterate on
-type RegionIterator interface {
-	ForEachRegion(func(*Region) bool)
-}
-
 // Region represents a group of zones geographically related
 type Region struct {
 	m     *Cluster
@@ -210,11 +204,6 @@ func (z *Zone) SyncRegions() error {
 			} else {
 				err = p.WriteStringFile("none\n", "region")
 			}
-
-			if err == nil {
-				err = p.RemoveFile(RegionClusterTokenFileName)
-			}
-
 			return err != nil
 		})
 	}