asciigoat
/
httools
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Labels Milestones

htpasswd: implement sha256 and sha512 algorithms #2

Merged
amery merged 1 commits from pr-karasz-shas into master 1 year ago
Conversation 0 Commits 1 Files Changed 3
karasz commented 1 year ago
Owner

Signed-off-by: Nagy Károly Gábriel k@jpi.io

Signed-off-by: Nagy Károly Gábriel <k@jpi.io>
karasz added 1 commit 1 year ago
6a24de7687
htpasswd: implement sha256 and sha512 algorithms
karasz requested review from amery 1 year ago
amery reviewed 1 year ago
htpasswd/htpasswd.go
case HashSHA512:
return verifySHA512(pass, hash)
}
return fmt.Errorf("unsupported hash algorithm %v", alg)
amery commented 1 year ago
Owner

default:?

`default:`?
amery approved these changes 1 year ago
amery left a comment
Owner

it looks to me as if code could be greatly reduced by using the interfaces, but +1

it looks to me as if code could be greatly reduced by using the interfaces, but +1
amery merged commit c2737bef29 into master 1 year ago
amery deleted branch pr-karasz-shas 1 year ago

Reviewers

amery approved these changes 1 year ago
The pull request has been merged as c2737bef29.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
amery
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pr-karasz-shas'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes