asciigoat/httools
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

htpasswd: implement sha256 and sha512 algorithms #2

Merged
amery merged 1 commits from pr-karasz-shas into master 2023-09-25 19:36:20 +02:00
Conversation 2 Commits 1 Files Changed 3
+97 -3
karasz commented 2023-09-25 13:31:05 +02:00
Owner
Copy Link
Copy Source

Signed-off-by: Nagy Károly Gábriel k@jpi.io

Signed-off-by: Nagy Károly Gábriel <k@jpi.io>
karasz added 1 commit 2023-09-25 13:31:06 +02:00
htpasswd: implement sha256 and sha512 algorithms 6a24de7687 
Signed-off-by: Nagy Károly Gábriel <k@jpi.io>
karasz requested review from amery 2023-09-25 13:31:11 +02:00
amery reviewed 2023-09-25 19:33:34 +02:00
htpasswd/htpasswd.go
@@ -177,2 +185,4 @@
case HashSHA512:
return verifySHA512(pass, hash)
}
return fmt.Errorf("unsupported hash algorithm %v", alg)
amery commented 2023-09-25 19:33:34 +02:00
Owner
Copy Link
Copy Source

default:?

`default:`?
amery approved these changes 2023-09-25 19:35:32 +02:00
amery left a comment
Owner
Copy Link
Copy Source

it looks to me as if code could be greatly reduced by using the interfaces, but +1

it looks to me as if code could be greatly reduced by using the interfaces, but +1
amery merged commit c2737bef29 into master 2023-09-25 19:36:20 +02:00
amery deleted branch pr-karasz-shas 2023-09-25 19:36:20 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
amery
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amery (Alejandro Mery) karasz (Nagy Károly Gábriel)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: asciigoat/httools#2
Delete Branch "pr-karasz-shas"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?