asciigoat/ini
2
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

parser: introduce NewError() and ErrPlusPosition() #8

Merged
amery merged 3 commits from pr-amery-error into main 2023-09-04 19:33:25 +02:00
Conversation 4 Commits 3 Files Changed 3
+31 -21
amery commented 2023-09-04 17:22:11 +02:00
Owner
Copy Link
Copy Source

and cleanup existing code using NewError()

and cleanup existing code using NewError()
amery added 3 commits 2023-09-04 17:22:11 +02:00
parser: introduce NewError() to create lexer.Error using lexer.Position c3883cbb0d 
Signed-off-by: Alejandro Mery <amery@jpi.io>
basic: cleanup using parser.NewError() 85548312b0 
Signed-off-by: Alejandro Mery <amery@jpi.io>
parser: introduce ErrPlusPosition to apply a position offset to a lexer.Error 3bcdadf29a 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-09-04 17:22:57 +02:00
amery force-pushed pr-amery-error from 3bcdadf29a to 8f3e59ec36 2023-09-04 17:25:55 +02:00 Compare
amery commented 2023-09-04 17:27:14 +02:00
Author
Owner
Copy Link
Copy Source

amended to fix basic.decoder.OnError()'s shadowing of err

amended to fix `basic.decoder.OnError()`'s shadowing of `err`
karasz approved these changes 2023-09-04 19:24:44 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTM although it seems that for a while revive is kind of silent

LGTM although it seems that for a while revive is kind of silent
👍 1
amery commented 2023-09-04 19:32:14 +02:00
Author
Owner
Copy Link
Copy Source

LGTM although it seems that for a while revive is kind of silent

anything in particular you had expected revive to complain about?

> LGTM although it seems that for a while revive is kind of silent anything in particular you had expected revive to complain about?
amery merged commit d8af7821e4 into main 2023-09-04 19:33:25 +02:00
amery deleted branch pr-amery-error 2023-09-04 19:33:25 +02:00
amery commented 2023-09-04 19:36:31 +02:00
Author
Owner
Copy Link
Copy Source

v0.2.4 tagged

`v0.2.4` tagged
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
amery (Alejandro Mery) karasz (Nagy Károly Gábriel)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: asciigoat/ini#8
Delete Branch "pr-amery-error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?