parser: introduce NewError() and ErrPlusPosition() #8

Merged

amery merged 3 commits from pr-amery-error into main 1 year ago

amery commented 1 year ago

Owner

and cleanup existing code using NewError()

amery added 3 commits 1 year ago

c3883cbb0d parser: introduce NewError() to create lexer.Error using lexer.Position

Signed-off-by: Alejandro Mery <amery@jpi.io>

85548312b0 basic: cleanup using parser.NewError()

Signed-off-by: Alejandro Mery <amery@jpi.io>

3bcdadf29a parser: introduce ErrPlusPosition to apply a position offset to a lexer.Error

Signed-off-by: Alejandro Mery <amery@jpi.io>

amery requested review from karasz 1 year ago

amery force-pushed pr-amery-error from 3bcdadf29a to 8f3e59ec36 1 year ago

amery commented 1 year ago

Poster

Owner

amended to fix basic.decoder.OnError()'s shadowing of err

karasz approved these changes 1 year ago

karasz left a comment

Owner

LGTM although it seems that for a while revive is kind of silent

👍 1

amery commented 1 year ago

Poster

Owner

LGTM although it seems that for a while revive is kind of silent

anything in particular you had expected revive to complain about?

amery merged commit d8af7821e4 into main 1 year ago

amery deleted branch pr-amery-error 1 year ago

amery referenced this issue from a commit 1 year ago

Merge pull request 'parser: introduce NewError() and ErrPlusPosition()' (#8)

amery commented 1 year ago

Poster

Owner

v0.2.4 tagged

Reviewers

karasz approved these changes 1 year ago

The pull request has been merged as d8af7821e4.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.