Nagy Károly Gábriel

karasz approved asciigoat/core#8

2023-08-29 18:36:17 +02:00

lexer: introduce a Position (Line, Column) handler

LGTM

karasz approved asciigoat/ini#1

2023-08-29 17:42:20 +02:00

build-sys: import build system from darvaza.org/core

OK

karasz approved asciigoat/core#7

2023-08-29 17:24:47 +02:00

build-sys: import build system from darvaza.org/core

OK

karasz approved asciigoat/core#6

2023-08-29 16:01:25 +02:00

lexer: introduce Error{}

LGTM

karasz suggested changes for asciigoat/core#5

2023-08-29 16:00:41 +02:00

lexer: Reader.Accept(), AcceptAll(), and StateFn

Can you please rewrite the Run function, your usage of fn is confusing, also err being just declared gets the default value on first iteration which should be nil hence breaking the for loop

karasz approved asciigoat/core#4

2023-08-29 09:57:23 +02:00

lexer: rename runes.Reader to lexer.Reader and implement UnreadRune() and PeekRune()

LGTM

karasz approved asciigoat/core#1

2023-08-29 09:55:49 +02:00

introduce NewReadCloser to allow byte and string buffers to offer io.ReadCloser

LGTM

karasz approved amery/jpictl#6

2023-08-28 18:17:57 +02:00

zones: add methods to work with files at the root of m/

LGTM

karasz approved amery/jpictl#4

2023-08-28 18:07:55 +02:00

zones: Env: allow multiple gateways and drop unused ZONE{zoneID}_IP

LGTMN

karasz approved amery/jpictl#5

2023-08-28 18:05:57 +02:00

zone.ScanOptions, custom resolver and prevent unnecessary DNS calls

LGTM

karasz commented on pull request amery/jpictl#4

2023-08-28 17:54:46 +02:00

zones: Env: allow multiple gateways and drop unused ZONE{zoneID}_IP

please see comment

karasz commented on pull request amery/jpictl#4

2023-08-28 17:54:46 +02:00

zones: Env: allow multiple gateways and drop unused ZONE{zoneID}_IP

I would make it like:

karasz approved amery/jpictl#3

2023-08-28 08:49:13 +02:00

zones: FilterMachines() and Zone.GatewayIDs()

LGTM

karasz approved amery/jpictl#2

2023-08-28 08:46:00 +02:00

env: introduce Env() factory and jpictl env -e to export variables

LGTM

karasz approved amery/jpictl#1

2023-08-28 08:44:55 +02:00

zones: fix PruneWireguardConfig recursion

LGTM

karasz pushed to master at JPI/ranpass

2020-12-23 12:02:36 +01:00

baaeaf19df ranpas: remove all dependencies except stdlib

karasz pushed to master at karasz/fluxplug

2019-06-13 09:08:23 +02:00

90f0f1783a Update 'README.md'

karasz pushed to master at karasz/fluxplug

2019-04-04 18:16:18 +02:00

dcac1180a3 fluxplug: actually make packs plugin usable

karasz pushed to master at karasz/fluxplug

2019-04-04 17:20:54 +02:00

38a20c881e fluxplug: start the restructure of the project

karasz opened issue karasz/fluxplug#1

2019-03-18 15:01:31 +01:00

BUG:Errors from called programs slip unnoticed