Nagy Károly Gábriel

karasz commented on pull request amery/jpictl#9

2023-09-05 16:45:43 +02:00

ceph: add initial ceph support. reading and writing m/ceph.conf

Please also add // TODO: or // FIXME: explaining why this is needed

karasz suggested changes for amery/jpictl#9

2023-09-05 16:08:48 +02:00

ceph: add initial ceph support. reading and writing m/ceph.conf

Fine and dandy but segfaults if ceph.conf is not in the root of the machines. Please allow for ceph.conf to be in the proper place.

karasz approved asciigoat/ini#9

2023-09-05 13:29:14 +02:00

parser: Unquoted(), AcceptQuotedString() and SplitCommaArray

LGTM

karasz approved asciigoat/ini#8

2023-09-04 19:24:44 +02:00

parser: introduce NewError() and ErrPlusPosition()

LGTM although it seems that for a while revive is kind of silent

karasz approved asciigoat/ini#7

2023-09-04 15:42:16 +02:00

parser: introduce TextParser and refactor Parser

LGTMN

karasz suggested changes for asciigoat/ini#7

2023-09-04 10:40:37 +02:00

parser: introduce TextParser and refactor Parser

this requires asciigoat 0.3.8, but mod file is not updated to reflect that

karasz approved asciigoat/core#13

2023-09-04 10:31:08 +02:00

lexer: introduce Position.Add()

LGTM

karasz approved asciigoat/core#12

2023-09-04 10:30:23 +02:00

lexer: add Hint to Error, which is expanded as "%s" instead of "%q"

LGTM

karasz approved asciigoat/ini#5

2023-09-02 17:26:31 +02:00

basic: implement Section.String() and Field.String()

LGTM

karasz approved asciigoat/ini#4

2023-09-01 16:59:56 +02:00

basic: introduce basic one-shot INI-style decoder

let's go with this

karasz approved asciigoat/ini#3

2023-09-01 15:01:08 +02:00

README: add initial description of the package

LGTM

karasz suggested changes for asciigoat/ini#3

2023-09-01 09:06:34 +02:00

README: add initial description of the package

I see that you added "other" implementations. In this case please add a short paragraph on how is asciigoat's ini parser different/better, why should one choose this implementation over the others.

karasz approved asciigoat/core#11

2023-08-31 17:55:20 +02:00

README: add initial description of the package

+100

karasz approved asciigoat/core#10

2023-08-31 16:39:17 +02:00

lexer: introduce NewIsInRunes() shortcut for NewIsIn()

OK

karasz approved asciigoat/ini#2

2023-08-31 09:25:46 +02:00

parser: implement basic dosini parsing

LGTM

karasz approved asciigoat/core#9

2023-08-30 09:13:51 +02:00

lexer: constants and helpers

LGTM

karasz approved asciigoat/core#5

2023-08-30 09:12:27 +02:00

lexer: Reader.Accept(), AcceptAll(), and StateFn

OK

karasz pushed to dev-amery-cmd-gateway at amery/jpictl

2023-08-29 20:50:23 +02:00

3d5a766161 jpictl: introduce gateway command

karasz created pull request amery/jpictl#7

2023-08-29 18:40:51 +02:00

jpictl: introduce gateway command

karasz pushed to dev-amery-cmd-gateway at amery/jpictl

2023-08-29 18:39:46 +02:00

0b3290f270 jpictl: introduce gateway command