Browse Source

zones: introduce WithLogger() scan option

Signed-off-by: Alejandro Mery <amery@jpi.io>
pull/12/head
Alejandro Mery 1 year ago
parent
commit
45447275a7
  1. 1
      cmd/jpictl/config.go
  2. 1
      cmd/jpictl/log.go
  3. 1
      go.mod
  4. 2
      go.sum
  5. 26
      pkg/zones/options.go

1
cmd/jpictl/config.go

@ -17,5 +17,6 @@ var cfg = &Config{
func (cfg *Config) LoadZones(resolve bool) (*zones.Zones, error) { func (cfg *Config) LoadZones(resolve bool) (*zones.Zones, error) {
return zones.New(cfg.Base, cfg.Domain, return zones.New(cfg.Base, cfg.Domain,
zones.ResolvePublicAddresses(resolve), zones.ResolvePublicAddresses(resolve),
zones.WithLogger(log),
) )
} }

1
cmd/jpictl/log.go

@ -7,6 +7,7 @@ import (
"darvaza.org/slog" "darvaza.org/slog"
) )
// TODO: make log level configurable via flags
var ( var (
log = zerolog.New(nil, slog.Debug) log = zerolog.New(nil, slog.Debug)
) )

1
go.mod

@ -8,6 +8,7 @@ require (
darvaza.org/resolver v0.5.4 darvaza.org/resolver v0.5.4
darvaza.org/sidecar v0.0.2 darvaza.org/sidecar v0.0.2
darvaza.org/slog v0.5.3 darvaza.org/slog v0.5.3
darvaza.org/slog/handlers/discard v0.4.5
github.com/burntSushi/toml v0.3.1 github.com/burntSushi/toml v0.3.1
github.com/gofrs/uuid/v5 v5.0.0 github.com/gofrs/uuid/v5 v5.0.0
github.com/hack-pad/hackpadfs v0.2.1 github.com/hack-pad/hackpadfs v0.2.1

2
go.sum

@ -10,6 +10,8 @@ darvaza.org/sidecar v0.0.2 h1:4H8FUxc43kkLjxdShN1CoxLTcoHQsZjDVwm7kt6eIK0=
darvaza.org/sidecar v0.0.2/go.mod h1:yFC3Qt3j+uS7n9CMpLxwrA68z+FNJhENoenBc9zBJJo= darvaza.org/sidecar v0.0.2/go.mod h1:yFC3Qt3j+uS7n9CMpLxwrA68z+FNJhENoenBc9zBJJo=
darvaza.org/slog v0.5.3 h1:sQzmZXgqRh9oFMKBwEYrEpucLvKJVZxaxa2bHIA6GJ0= darvaza.org/slog v0.5.3 h1:sQzmZXgqRh9oFMKBwEYrEpucLvKJVZxaxa2bHIA6GJ0=
darvaza.org/slog v0.5.3/go.mod h1:59d+yi+C7gn4pDDuwbbOKawERpdXthFFk1Yc+Sv6XB0= darvaza.org/slog v0.5.3/go.mod h1:59d+yi+C7gn4pDDuwbbOKawERpdXthFFk1Yc+Sv6XB0=
darvaza.org/slog/handlers/discard v0.4.5 h1:RRykOItNolHyiUav57lG/GFBL33rcljoa0nWTpY+T0g=
darvaza.org/slog/handlers/discard v0.4.5/go.mod h1:HYHfISQjMqcPbPoPZ92ib/u7s9JcXvF6OaygpPFwdF8=
darvaza.org/slog/handlers/filter v0.4.5 h1:CX1bMzldd67e3y3s3Sh4jK8Lyo0WMvTGBB2lD315jhc= darvaza.org/slog/handlers/filter v0.4.5 h1:CX1bMzldd67e3y3s3Sh4jK8Lyo0WMvTGBB2lD315jhc=
darvaza.org/slog/handlers/filter v0.4.5/go.mod h1:OuH9rHYg9CIErTJCZliMnFexBfP/HJ9PZ1V1VwSCZ1g= darvaza.org/slog/handlers/filter v0.4.5/go.mod h1:OuH9rHYg9CIErTJCZliMnFexBfP/HJ9PZ1V1VwSCZ1g=
darvaza.org/slog/handlers/zerolog v0.4.5 h1:W4cgGORx4wImr+RL96CWSQGTdkZzKX6YHXPSYJvdoB4= darvaza.org/slog/handlers/zerolog v0.4.5 h1:W4cgGORx4wImr+RL96CWSQGTdkZzKX6YHXPSYJvdoB4=

26
pkg/zones/options.go

@ -5,10 +5,12 @@ import (
"path/filepath" "path/filepath"
"darvaza.org/resolver" "darvaza.org/resolver"
"darvaza.org/slog"
"darvaza.org/slog/handlers/discard"
"github.com/hack-pad/hackpadfs/os" "github.com/hack-pad/hackpadfs/os"
) )
// A ScanOption preconfigures the Zones before scanning // A ScanOption pre-configures the Zones before scanning
type ScanOption func(*Zones, *ScanOptions) error type ScanOption func(*Zones, *ScanOptions) error
// ScanOptions contains flags used by the initial scan // ScanOptions contains flags used by the initial scan
@ -17,6 +19,10 @@ type ScanOptions struct {
// pre-populate Machine.PublicAddresses during the // pre-populate Machine.PublicAddresses during the
// initial scan // initial scan
DontResolvePublicAddresses bool DontResolvePublicAddresses bool
// Logger specifies the logger to be used. otherwise
// the scanner will be mute
slog.Logger
} }
// ResolvePublicAddresses instructs the scanner to use // ResolvePublicAddresses instructs the scanner to use
@ -55,6 +61,18 @@ func WithResolver(h resolver.Resolver) ScanOption {
} }
} }
// WithLogger specifies what to use for logging
func WithLogger(log slog.Logger) ScanOption {
return func(m *Zones, opt *ScanOptions) error {
if log == nil {
log = discard.New()
}
opt.Logger = log
return nil
}
}
func (m *Zones) setDefaults(opt *ScanOptions) error { func (m *Zones) setDefaults(opt *ScanOptions) error {
if m.resolver == nil { if m.resolver == nil {
h := resolver.NewCloudflareLookuper() h := resolver.NewCloudflareLookuper()
@ -64,6 +82,12 @@ func (m *Zones) setDefaults(opt *ScanOptions) error {
} }
} }
if opt.Logger == nil {
if err := WithLogger(nil)(m, opt); err != nil {
return err
}
}
return nil return nil
} }

Loading…
Cancel
Save