Merge pull request 'cluster: ensure ceph monitors are set when loading a config file' (#23)

Reviewed-on: #23

.vscode/settings.json

@@ -6,9 +6,6 @@
         "darvaza",
         "gofrs",
         "jpictl",
-        "libdns",
-        "Lookuper",
-        "publicsuffix",
         "Wrapf",
         "zerolog"
     ]

cmd/jpictl/dns.go

@@ -1,75 +0,0 @@
-package main
-
-import (
-	"context"
-	"os"
-
-	"github.com/spf13/cobra"
-
-	"git.jpi.io/amery/jpictl/pkg/cluster"
-	"git.jpi.io/amery/jpictl/pkg/dns"
-)
-
-func newDNSManager(m *cluster.Cluster) (*dns.Manager, error) {
-	domain := m.Domain
-	if m.Name != "" {
-		domain = m.Name + "." + domain
-	}
-
-	mgr, err := dns.NewManager(dns.WithDomain(domain), dns.WithLogger(log))
-	if err != nil {
-		return nil, err
-	}
-
-	m.ForEachZone(func(z *cluster.Zone) bool {
-		z.ForEachMachine(func(p *cluster.Machine) bool {
-			err = mgr.AddHost(context.TODO(), z.Name, p.ID, true, p.PublicAddresses...)
-			return err != nil
-		})
-
-		return err != nil
-	})
-
-	if err != nil {
-		return nil, err
-	}
-
-	for _, r := range m.Regions {
-		err := mgr.AddRegion(context.TODO(), r.Name, r.Zones()...)
-		if err != nil {
-			return nil, err
-		}
-	}
-
-	return mgr, nil
-}
-
-// Command
-var dnsCmd = &cobra.Command{
-	Use: "dns",
-}
-
-var dnsWriteCmd = &cobra.Command{
-	Use:    "write",
-	PreRun: setVerbosity,
-	RunE: func(_ *cobra.Command, _ []string) error {
-		m, err := cfg.LoadZones(true)
-		if err != nil {
-			return err
-		}
-
-		mgr, err := newDNSManager(m)
-		if err != nil {
-			return err
-		}
-
-		_, err = mgr.WriteTo(os.Stdout)
-		return err
-	},
-}
-
-func init() {
-	rootCmd.AddCommand(dnsCmd)
-
-	dnsCmd.AddCommand(dnsWriteCmd)
-}

go.mod

@@ -2,8 +2,6 @@ module git.jpi.io/amery/jpictl
 
 go 1.19
 
-replace asciigoat.org/ini => ../../../asciigoat.org/ini
-
 require (
 	asciigoat.org/ini v0.2.5
 	darvaza.org/core v0.9.8
@@ -13,12 +11,10 @@ require (
 	darvaza.org/slog/handlers/discard v0.4.5
 	github.com/gofrs/uuid/v5 v5.0.0
 	github.com/hack-pad/hackpadfs v0.2.1
-	github.com/libdns/cloudflare v0.1.0
-	github.com/libdns/libdns v0.2.1
 	github.com/mgechev/revive v1.3.3
 	github.com/spf13/cobra v1.7.0
 	golang.org/x/crypto v0.12.0
-	golang.org/x/net v0.14.0
+	gopkg.in/gcfg.v1 v1.2.3
 	gopkg.in/yaml.v3 v3.0.1
 )
 
@@ -43,7 +39,9 @@ require (
 	github.com/rs/zerolog v1.30.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
 	golang.org/x/mod v0.12.0 // indirect
+	golang.org/x/net v0.14.0 // indirect
 	golang.org/x/sys v0.12.0 // indirect
 	golang.org/x/text v0.13.0 // indirect
 	golang.org/x/tools v0.12.0 // indirect
+	gopkg.in/warnings.v0 v0.1.2 // indirect
 )

go.sum

@@ -1,5 +1,7 @@
 asciigoat.org/core v0.3.9 h1:hgDDz4ecm3ZvehX++m8A/IzAt+B5oDPiRtxatzfUHPQ=
 asciigoat.org/core v0.3.9/go.mod h1:CAaHwyw8MpAq4a1MYtN2dxJrsK+hmIdW50OndaQZYPI=
+asciigoat.org/ini v0.2.5 h1:4gRIp9rU+XQt8+HMqZO5R7GavMv9Yl2+N+je6djDIAE=
+asciigoat.org/ini v0.2.5/go.mod h1:gmXzJ9XFqf1NLk5nQkj04USQ4tMtdRJHNQX6vp3DzjU=
 darvaza.org/core v0.9.8 h1:luLxgfUc2pzuusYPo/Z/dC/qr9XZPKpSQw8/kS7zNUM=
 darvaza.org/core v0.9.8/go.mod h1:Dbme64naxeshQfxcVJX9ZT7AiGyIY8kldfuELVtf8mw=
 darvaza.org/resolver v0.5.4 h1:dlSBNV14yYsp7Kg7ipwYOMNsLbrpeXa8Z0HBTa0Ryxs=
@@ -34,11 +36,6 @@ github.com/hack-pad/hackpadfs v0.2.1 h1:FelFhIhv26gyjujoA/yeFO+6YGlqzmc9la/6iKMI
 github.com/hack-pad/hackpadfs v0.2.1/go.mod h1:khQBuCEwGXWakkmq8ZiFUvUZz84ZkJ2KNwKvChs4OrU=
 github.com/inconshreveable/mousetrap v1.1.0 h1:wN+x4NVGpMsO7ErUn/mUI3vEoE6Jt13X2s0bqwp9tc8=
 github.com/inconshreveable/mousetrap v1.1.0/go.mod h1:vpF70FUmC8bwa3OWnCshd2FqLfsEA9PFc4w1p2J65bw=
-github.com/libdns/cloudflare v0.1.0 h1:93WkJaGaiXCe353LHEP36kAWCUw0YjFqwhkBkU2/iic=
-github.com/libdns/cloudflare v0.1.0/go.mod h1:a44IP6J1YH6nvcNl1PverfJviADgXUnsozR3a7vBKN8=
-github.com/libdns/libdns v0.2.0/go.mod h1:yQCXzk1lEZmmCPa857bnk4TsOiqYasqpyOEeSObbb40=
-github.com/libdns/libdns v0.2.1 h1:Wu59T7wSHRgtA0cfxC+n1c/e+O3upJGWytknkmFEDis=
-github.com/libdns/libdns v0.2.1/go.mod h1:yQCXzk1lEZmmCPa857bnk4TsOiqYasqpyOEeSObbb40=
 github.com/mattn/go-colorable v0.1.12/go.mod h1:u5H1YNBxpqRaxsYJYSkiCWKzEfiAb1Gb520KVy5xxl4=
 github.com/mattn/go-colorable v0.1.13 h1:fFA4WZxdEF4tXPZVKMLwD8oUnCTTo08duU7wxecdEvA=
 github.com/mattn/go-colorable v0.1.13/go.mod h1:7S9/ev0klgBDR4GtXTXX8a3vIGJpMovkB8vQcUbaXHg=
@@ -101,6 +98,10 @@ golang.org/x/tools v0.12.0 h1:YW6HUoUmYBpwSgyaGaZq1fHjrBjX1rlpZ54T6mu2kss=
 golang.org/x/tools v0.12.0/go.mod h1:Sc0INKfu04TlqNoRA1hgpFZbhYXHPr4V5DzpSBTPqQM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
+gopkg.in/gcfg.v1 v1.2.3 h1:m8OOJ4ccYHnx2f4gQwpno8nAX5OGOh7RLaaz0pj3Ogs=
+gopkg.in/gcfg.v1 v1.2.3/go.mod h1:yesOnuUOFQAhST5vPY4nbZsb/huCgGGXlipJsBn0b3o=
+gopkg.in/warnings.v0 v0.1.2 h1:wFXVbFY8DY5/xOe1ECiWdKCzZlxgshcYVNkBHstARME=
+gopkg.in/warnings.v0 v0.1.2/go.mod h1:jksf8JmL6Qr/oQM2OXTHunEvvTAsrWBLb6OOjuVWRNI=
 gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
 gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
 gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=

pkg/cluster/regions.go

@@ -9,15 +9,6 @@ type Region struct {
 	Regions []string `json:",omitempty" yaml:",omitempty"`
 }
 
-// Zones ...
-func (r *Region) Zones() []string {
-	out := make([]string, len(r.zones))
-	for i := range r.zones {
-		out[i] = r.zones[i].Name
-	}
-	return out
-}
-
 func (m *Cluster) initRegions(_ *ScanOptions) error {
 	regions := make(map[string][]*Zone)
 

pkg/dns/dns.go

@@ -1,34 +0,0 @@
-// Package dns manages DNS entries for the cluster
-package dns
-
-import "net/netip"
-
-// // A Config defines a Region
-//
-//	type Config struct {
-//		// Name is the identifier of this Region
-//		Name string
-//		// Regions are a list of (sub)regions that belong to this Region
-//		Regions []string
-//		// Zones are a list of Zones that directly belong to this Region
-//		Zones []string
-//	}
-//
-//	type Region struct {
-//		Name string
-//	}
-
-// Zone represents a set of machines with high affinity
-type Zone struct {
-	Name string
-
-	Machines map[int]*Machine
-}
-
-// Machine represents a member of the cluster
-type Machine struct {
-	ID int
-
-	Active bool
-	Addrs  []netip.Addr
-}

pkg/dns/host.go

@@ -1,41 +0,0 @@
-package dns
-
-import (
-	"context"
-	"io/fs"
-	"net/netip"
-)
-
-// AddHost registers a machine
-func (mgr *Manager) AddHost(_ context.Context, zone string, id int,
-	active bool, addrs ...netip.Addr) error {
-	//
-	if zone == "" || id <= 0 {
-		return fs.ErrInvalid
-	}
-
-	z, ok := mgr.zones[zone]
-	if !ok {
-		z = &Zone{
-			Name:     zone,
-			Machines: make(map[int]*Machine),
-		}
-
-		mgr.zones[zone] = z
-	}
-
-	z.Machines[id] = &Machine{
-		ID:     id,
-		Active: active,
-		Addrs:  SortAddrSlice(addrs),
-	}
-
-	return nil
-}
-
-// AddRegion specifies a new region and the zones it contains
-func (mgr *Manager) AddRegion(_ context.Context, region string, zones ...string) error {
-	mgr.l.Debug().WithField("region", region).WithField("zones", zones).Print()
-	mgr.regions[region] = append(mgr.regions[region], zones...)
-	return nil
-}

pkg/dns/manager.go

@@ -1,124 +0,0 @@
-package dns
-
-import (
-	"errors"
-	"strings"
-	"sync"
-
-	"darvaza.org/core"
-	"darvaza.org/slog"
-	"git.jpi.io/amery/jpictl/pkg/cluster"
-	"golang.org/x/net/publicsuffix"
-)
-
-// Manager is a DNS Manager instance
-type Manager struct {
-	mu sync.Mutex
-
-	domain  string
-	suffix  string
-	zones   map[string]*Zone
-	regions map[string][]string
-
-	p Provider
-	l slog.Logger
-}
-
-// ManagerOption configures a Manager
-type ManagerOption func(*Manager) error
-
-func newErrorManagerOption(err error, hint string) ManagerOption {
-	return func(*Manager) error {
-		if hint != "" {
-			err = core.Wrap(err, hint)
-		}
-		return err
-	}
-}
-
-// WithProvider attaches a libdns Provider to the Manager
-func WithProvider(p Provider) ManagerOption {
-	var err error
-
-	if p == nil {
-		p, err = DefaultDNSProvider()
-	}
-
-	if err != nil {
-		return newErrorManagerOption(err, "WithProvider")
-	}
-
-	return func(mgr *Manager) error {
-		mgr.p = p
-		return nil
-	}
-}
-
-// WithLogger attaches a logger to the Manager
-func WithLogger(log slog.Logger) ManagerOption {
-	if log == nil {
-		log = cluster.DefaultLogger()
-	}
-
-	return func(mgr *Manager) error {
-		mgr.l = log
-		return nil
-	}
-}
-
-func (mgr *Manager) setDefaults() error {
-	var opts []ManagerOption
-
-	if mgr.l == nil {
-		opts = append(opts, WithLogger(nil))
-	}
-
-	if mgr.domain == "" || mgr.suffix == "" {
-		return errors.New("domain not specified")
-	}
-
-	mgr.zones = make(map[string]*Zone)
-	mgr.regions = make(map[string][]string)
-
-	for _, opt := range opts {
-		if err := opt(mgr); err != nil {
-			return err
-		}
-	}
-	return nil
-}
-
-// WithDomain specifies where the manager operates
-func WithDomain(domain string) ManagerOption {
-	base, err := publicsuffix.EffectiveTLDPlusOne(domain)
-	if err != nil {
-		return newErrorManagerOption(err, "publicsuffix")
-	}
-
-	suffix := strings.TrimSuffix(domain, base)
-	if suffix != "" {
-		suffix = "." + suffix[:len(suffix)-1]
-	}
-
-	return func(mgr *Manager) error {
-		mgr.domain = base
-		mgr.suffix = suffix
-		return nil
-	}
-}
-
-// NewManager creates a DNS manager with the
-func NewManager(opts ...ManagerOption) (*Manager, error) {
-	mgr := new(Manager)
-
-	for _, opt := range opts {
-		if err := opt(mgr); err != nil {
-			return nil, err
-		}
-	}
-
-	if err := mgr.setDefaults(); err != nil {
-		return nil, err
-	}
-	return mgr, nil
-}

pkg/dns/provider.go

@@ -1,36 +0,0 @@
-package dns
-
-import (
-	"fmt"
-	"os"
-
-	"github.com/libdns/cloudflare"
-	"github.com/libdns/libdns"
-)
-
-const (
-	// CloudflareAPIToken is the environment variable
-	// containing the API Token
-	CloudflareAPIToken = "CLOUDFLARE_DNS_API_TOKEN"
-)
-
-// Provider manages DNS entries
-type Provider interface {
-	libdns.RecordGetter
-	libdns.RecordDeleter
-}
-
-// DefaultDNSProvider returns a cloudflare DNS provider
-// using an API Token from env [CloudflareAPIToken]
-func DefaultDNSProvider() (*cloudflare.Provider, error) {
-	s := os.Getenv(CloudflareAPIToken)
-	if s == "" {
-		return nil, fmt.Errorf("%q: %s", CloudflareAPIToken, "not found")
-	}
-
-	p := &cloudflare.Provider{
-		APIToken: s,
-	}
-
-	return p, nil
-}

pkg/dns/record.go

@@ -1,121 +0,0 @@
-package dns
-
-import (
-	"fmt"
-	"net/netip"
-	"sort"
-	"time"
-
-	"darvaza.org/core"
-	"github.com/libdns/libdns"
-)
-
-// SortAddrSlice ...
-func SortAddrSlice(s []netip.Addr) []netip.Addr {
-	sort.Slice(s, func(i, j int) bool {
-		return s[i].Less(s[j])
-	})
-	return s
-}
-
-// AddrRecord represents an A or AAAA record
-type AddrRecord struct {
-	Name string
-	Addr []netip.Addr
-}
-
-// Sort sorts the addresses of the record
-func (rr *AddrRecord) Sort() {
-	SortAddrSlice(rr.Addr)
-}
-
-// Export converts the record into libdns.Record
-func (rr *AddrRecord) Export() []libdns.Record {
-	out := make([]libdns.Record, len(rr.Addr))
-	for i, addr := range rr.Addr {
-		out[i] = libdns.Record{
-			Name:  rr.Name,
-			TTL:   time.Second * 1,
-			Type:  core.IIf(addr.Is6(), "AAAA", "A"),
-			Value: addr.String(),
-		}
-	}
-
-	return out
-}
-
-func (mgr *Manager) genAllAddrRecords() []AddrRecord {
-	var out []AddrRecord
-
-	cache := make(map[string][]netip.Addr)
-
-	// zones
-	for _, z := range mgr.zones {
-		// machines
-		s := mgr.genZoneMachineRecords(z)
-		out = append(out, s...)
-
-		// zone alias
-		addrs := mgr.genZoneAddresses(z)
-		name := z.Name
-
-		out = append(out, AddrRecord{
-			Name: name + mgr.suffix,
-			Addr: addrs,
-		})
-
-		// and cache for regions
-		cache[name] = addrs
-	}
-
-	// regions
-	for name, zones := range mgr.regions {
-		var addrs []netip.Addr
-
-		for _, z := range zones {
-			addrs = append(addrs, cache[z]...)
-		}
-
-		rec := AddrRecord{
-			Name: name + mgr.suffix,
-			Addr: addrs,
-		}
-		rec.Sort()
-
-		out = append(out, rec)
-	}
-
-	// sort
-	sort.Slice(out, func(i, j int) bool {
-		return out[i].Name < out[j].Name
-	})
-
-	return out
-}
-
-func (*Manager) genZoneAddresses(z *Zone) []netip.Addr {
-	var out []netip.Addr
-
-	for _, p := range z.Machines {
-		if p.Active {
-			out = append(out, p.Addrs...)
-		}
-	}
-
-	SortAddrSlice(out)
-	return out
-}
-
-func (mgr *Manager) genZoneMachineRecords(z *Zone) []AddrRecord {
-	out := make([]AddrRecord, 0, len(z.Machines))
-
-	for _, p := range z.Machines {
-		rec := AddrRecord{
-			Name: fmt.Sprintf("%s-%v%s", z.Name, p.ID, mgr.suffix),
-			Addr: p.Addrs,
-		}
-		out = append(out, rec)
-	}
-
-	return out
-}

pkg/dns/write.go

@@ -1,35 +0,0 @@
-package dns
-
-import (
-	"bytes"
-	"fmt"
-	"io"
-	"time"
-
-	"github.com/libdns/libdns"
-)
-
-// WriteTo writes the DNS data for the cluster
-func (mgr *Manager) WriteTo(w io.Writer) (int64, error) {
-	var buf bytes.Buffer
-
-	records := mgr.genAllAddrRecords()
-	for i := range records {
-		r := &records[i]
-		r.Name = fmt.Sprintf("%s.%s.", r.Name, mgr.domain)
-	}
-
-	for _, rr1 := range records {
-		for _, rr2 := range rr1.Export() {
-			writeRecord(&buf, rr2)
-		}
-	}
-
-	return buf.WriteTo(w)
-}
-
-func writeRecord(w io.Writer, rr libdns.Record) {
-	_, _ = fmt.Fprintf(w, "%s\t%v\tIN\t%s\t%s\n",
-		rr.Name, int(rr.TTL/time.Second),
-		rr.Type, rr.Value)
-}

pkg/wireguard/config.go

@@ -2,6 +2,7 @@ package wireguard
 
 import (
 	"bytes"
+	"errors"
 	"fmt"
 	"io"
 	"net/netip"
@@ -9,8 +10,8 @@ import (
 	"strings"
 	"text/template"
 
-	"asciigoat.org/ini/basic"
 	"darvaza.org/core"
+	"gopkg.in/gcfg.v1"
 )
 
 var configTemplate = template.Must(template.New("config").Funcs(template.FuncMap{
@@ -106,11 +107,6 @@ func (ep EndpointAddress) String() string {
 	}
 }
 
-// UnmarshalText loads an endpoint address from text data
-func (ep *EndpointAddress) UnmarshalText(b []byte) error {
-	return ep.FromString(string(b))
-}
-
 // FromString sets the EndpointAddress from a given "[host]:port"
 func (ep *EndpointAddress) FromString(s string) error {
 	host, port, err := core.SplitHostPort(s)
@@ -131,6 +127,98 @@ func (ep *EndpointAddress) FromString(s string) error {
 	return nil
 }
 
+type intermediateConfig struct {
+	Interface interfaceConfig
+	Peer      peersConfig
+}
+
+func (v *intermediateConfig) Export() (*Config, error) {
+	var out Config
+	var err error
+
+	// Interface
+	out.Interface, err = v.Interface.Export()
+	if err != nil {
+		return nil, err
+	}
+
+	// Peers
+	peers, ok := v.PeersCount()
+	if !ok {
+		return nil, errors.New("inconsistent Peer data")
+	}
+
+	for i := 0; i < peers; i++ {
+		p, err := v.ExportPeer(i)
+		if err != nil {
+			err = core.Wrapf(err, "Peer[%v]:", i)
+			return nil, err
+		}
+
+		out.Peer = append(out.Peer, p)
+	}
+
+	return &out, nil
+}
+
+type interfaceConfig struct {
+	Address    netip.Addr
+	PrivateKey string
+	ListenPort uint16
+}
+
+func (p interfaceConfig) Export() (InterfaceConfig, error) {
+	var err error
+
+	out := InterfaceConfig{
+		Address:    p.Address,
+		ListenPort: p.ListenPort,
+	}
+
+	out.PrivateKey, err = PrivateKeyFromBase64(p.PrivateKey)
+	if err != nil {
+		err = core.Wrap(err, "PrivateKey")
+		return InterfaceConfig{}, err
+	}
+
+	return out, nil
+}
+
+type peersConfig struct {
+	PublicKey  []string
+	Endpoint   []string
+	AllowedIPs []string
+}
+
+func (v *intermediateConfig) ExportPeer(i int) (PeerConfig, error) {
+	var out PeerConfig
+
+	// Endpoint
+	s := v.Peer.Endpoint[i]
+	err := out.Endpoint.FromString(s)
+	if err != nil {
+		err = core.Wrap(err, "Endpoint")
+		return out, err
+	}
+
+	// PublicKey
+	out.PublicKey, err = PublicKeyFromBase64(v.Peer.PublicKey[i])
+	if err != nil {
+		err = core.Wrap(err, "PublicKey")
+		return out, err
+	}
+
+	// AllowedIPs
+	s = v.Peer.AllowedIPs[i]
+	out.AllowedIPs, err = parseAllowedIPs(s)
+	if err != nil {
+		err = core.Wrap(err, "AllowedIPs")
+		return out, err
+	}
+
+	return out, nil
+}
+
 func parseAllowedIPs(data string) ([]netip.Prefix, error) {
 	var out []netip.Prefix
 
@@ -147,17 +235,25 @@ func parseAllowedIPs(data string) ([]netip.Prefix, error) {
 	return out, nil
 }
 
+func (v *intermediateConfig) PeersCount() (int, bool) {
+	c0 := len(v.Peer.Endpoint)
+	c1 := len(v.Peer.PublicKey)
+	c2 := len(v.Peer.AllowedIPs)
+
+	if c0 != c1 || c1 != c2 {
+		return 0, false
+	}
+
+	return c0, true
+}
+
 // NewConfigFromReader parses a wgN.conf file
 func NewConfigFromReader(r io.Reader) (*Config, error) {
-	doc, err := basic.Decode(r)
-	if err != nil {
+	temp := &intermediateConfig{}
+
+	if err := gcfg.ReadInto(temp, r); err != nil {
 		return nil, err
 	}
 
-	cfg, err := newConfigFromDocument(doc)
-	if err != nil {
-		return nil, err
-	}
-
-	return cfg, nil
+	return temp.Export()
 }

pkg/wireguard/config_parser.go

@@ -1,169 +0,0 @@
-package wireguard
-
-import (
-	"io/fs"
-	"strconv"
-
-	"asciigoat.org/ini/basic"
-	"darvaza.org/core"
-)
-
-type sectionHandler func(*Config, *basic.Section) error
-
-var sectionMap = map[string]func(*Config, *basic.Section) error{
-	"Interface": loadInterfaceConfSection,
-	"Peer":      loadPeerConfSection,
-}
-
-func loadConfSection(out *Config, src *basic.Section) error {
-	h, ok := sectionMap[src.Key]
-	if !ok {
-		return core.Wrapf(fs.ErrInvalid, "unknown section %q", src.Key)
-	}
-
-	return h(out, src)
-}
-
-func loadInterfaceConfSection(out *Config, src *basic.Section) error {
-	var cfg InterfaceConfig
-
-	for _, field := range src.Fields {
-		if err := loadInterfaceConfField(&cfg, field); err != nil {
-			return core.Wrap(err, "Interface")
-		}
-	}
-
-	out.Interface = cfg
-	return nil
-}
-
-func loadPeerConfSection(out *Config, src *basic.Section) error {
-	var cfg PeerConfig
-
-	for _, field := range src.Fields {
-		if err := loadPeerConfField(&cfg, field); err != nil {
-			return core.Wrapf(err, "Peer[%v]", len(out.Peer))
-		}
-	}
-
-	out.Peer = append(out.Peer, cfg)
-	return nil
-}
-
-// revive:disable:cyclomatic
-// revive:disable:cognitive-complexity
-
-func loadInterfaceConfField(cfg *InterfaceConfig, field basic.Field) error {
-	// revive:enable:cyclomatic
-	// revive:enable:cognitive-complexity
-
-	// TODO: refactor when asciigoat's ini parser learns to do reflection
-	switch field.Key {
-	case "Address":
-		if !core.IsZero(cfg.Address) {
-			return core.Wrapf(fs.ErrInvalid, "duplicate field %q", field.Key)
-		}
-
-		err := cfg.Address.UnmarshalText([]byte(field.Value))
-		switch {
-		case err != nil:
-			return core.Wrap(err, field.Key)
-		default:
-			return nil
-		}
-	case "PrivateKey":
-		if !core.IsZero(cfg.PrivateKey) {
-			return core.Wrapf(fs.ErrInvalid, "duplicate field %q", field.Key)
-		}
-
-		err := cfg.PrivateKey.UnmarshalText([]byte(field.Value))
-		switch {
-		case err != nil:
-			return core.Wrap(err, field.Key)
-		default:
-			return nil
-		}
-	case "ListenPort":
-		if cfg.ListenPort > 0 {
-			return core.Wrapf(fs.ErrInvalid, "duplicate field %q", field.Key)
-		}
-
-		u64, err := strconv.ParseUint(field.Value, 10, 16)
-		switch {
-		case err != nil:
-			return core.Wrap(err, field.Key)
-		case u64 == 0:
-			return core.Wrapf(fs.ErrInvalid, "invalid %q value", field.Key)
-		default:
-			cfg.ListenPort = uint16(u64)
-			return nil
-		}
-	default:
-		return core.Wrapf(fs.ErrInvalid, "unknown field %q", field.Key)
-	}
-}
-
-// revive:disable:cyclomatic
-// revive:disable:cognitive-complexity
-
-func loadPeerConfField(cfg *PeerConfig, field basic.Field) error {
-	// revive:enable:cyclomatic
-	// revive:enable:cognitive-complexity
-
-	switch field.Key {
-	case "PublicKey":
-		if !core.IsZero(cfg.PublicKey) {
-			return core.Wrapf(fs.ErrInvalid, "duplicate field %q", field.Key)
-		}
-
-		err := cfg.PublicKey.UnmarshalText([]byte(field.Value))
-		switch {
-		case err != nil:
-			return core.Wrap(err, field.Key)
-		default:
-			return nil
-		}
-	case "Endpoint":
-		if cfg.Endpoint.String() != "" {
-			return core.Wrapf(fs.ErrInvalid, "duplicate field %q", field.Key)
-		}
-
-		err := cfg.Endpoint.UnmarshalText([]byte(field.Value))
-		switch {
-		case err != nil:
-			return core.Wrap(err, field.Key)
-		default:
-			return nil
-		}
-	case "AllowedIPs":
-		s, err := parseAllowedIPs(field.Value)
-		switch {
-		case err != nil:
-			return core.Wrap(err, field.Key)
-		case len(s) > 0:
-			cfg.AllowedIPs = append(cfg.AllowedIPs, s...)
-			return nil
-		}
-	default:
-		return core.Wrapf(fs.ErrInvalid, "unknown field %q", field.Key)
-	}
-	return nil
-}
-
-func newConfigFromDocument(doc *basic.Document) (*Config, error) {
-	var out Config
-
-	if len(doc.Global) > 0 {
-		err := core.Wrap(fs.ErrInvalid, "fields before the first section")
-		return nil, err
-	}
-
-	for i := range doc.Sections {
-		src := &doc.Sections[i]
-		if err := loadConfSection(&out, src); err != nil {
-			return nil, err
-		}
-	}
-
-	return &out, nil
-}

pkg/wireguard/keys.go

@@ -51,30 +51,6 @@ func (pub PublicKey) String() string {
 	}
 }
 
-// UnmarshalText loads the value from base64
-func (key *PrivateKey) UnmarshalText(b []byte) error {
-	v, err := PrivateKeyFromBase64(string(b))
-	switch {
-	case err != nil:
-		return err
-	default:
-		*key = v
-		return nil
-	}
-}
-
-// UnmarshalText loads the value from base64
-func (pub *PublicKey) UnmarshalText(b []byte) error {
-	v, err := PublicKeyFromBase64(string(b))
-	switch {
-	case err != nil:
-		return err
-	default:
-		*pub = v
-		return nil
-	}
-}
-
 // MarshalJSON encodes the key for JSON, omitting empty.
 func (key PrivateKey) MarshalJSON() ([]byte, error) {
 	return encodeKeyJSON(key.String())