Alejandro Mery amery
  • Brighton, UK
  • Joined on 2015-05-02
amery commented on pull request asciigoat/httools#3 2023-09-27 20:31:15 +02:00
htpasswd: refactor and add Passwd methods

we may want errors that can be tested without parsing the content

amery suggested changes for asciigoat/httools#3 2023-09-27 20:27:18 +02:00
htpasswd: refactor and add Passwd methods

please see comments

amery commented on pull request asciigoat/httools#3 2023-09-27 20:27:18 +02:00
htpasswd: refactor and add Passwd methods

wouldn't it be better to return a split? (algo, hash, bool)?

amery commented on pull request asciigoat/httools#3 2023-09-27 20:27:18 +02:00
htpasswd: refactor and add Passwd methods

as it's a map, newpp and pp are actually the same map and both contain the new user

amery commented on pull request asciigoat/httools#3 2023-09-27 20:27:18 +02:00
htpasswd: refactor and add Passwd methods

begging for the Hasher interface

amery commented on pull request asciigoat/httools#3 2023-09-27 20:27:18 +02:00
htpasswd: refactor and add Passwd methods

method of the algo sharing an interface?

amery commented on pull request asciigoat/httools#3 2023-09-27 20:27:18 +02:00
htpasswd: refactor and add Passwd methods

standard is Bytes() as the returned value contains many

amery deleted branch pr-karasz-shas from asciigoat/httools 2023-09-25 19:36:21 +02:00
amery pushed to master at asciigoat/httools 2023-09-25 19:36:21 +02:00
c2737bef29 Merge pull request 'htpasswd: implement sha256 and sha512 algorithms' (#2)
6a24de7687 htpasswd: implement sha256 and sha512 algorithms
Compare 2 commits »
amery merged pull request asciigoat/httools#2 2023-09-25 19:36:20 +02:00
htpasswd: implement sha256 and sha512 algorithms
amery approved asciigoat/httools#2 2023-09-25 19:35:32 +02:00
htpasswd: implement sha256 and sha512 algorithms

it looks to me as if code could be greatly reduced by using the interfaces, but +1

amery commented on pull request asciigoat/httools#2 2023-09-25 19:33:34 +02:00
htpasswd: implement sha256 and sha512 algorithms

default:?

amery deleted branch dev-karasz-httpasswd from asciigoat/httools 2023-09-22 16:34:59 +02:00
amery pushed to master at asciigoat/httools 2023-09-22 16:34:59 +02:00
0cb9cb9359 Merge pull request 'htpasswd: implement routines for working with .htpasswd' (#1)
7f6b35e769 htpasswd: implement routines for working with .htpasswd
Compare 2 commits »
amery merged pull request asciigoat/httools#1 2023-09-22 16:34:59 +02:00
htpasswd: implement routines for working with .htpasswd
amery commented on pull request asciigoat/httools#1 2023-09-22 15:39:21 +02:00
htpasswd: implement routines for working with .htpasswd

thanks 😊

amery approved asciigoat/httools#1 2023-09-21 19:10:04 +02:00
htpasswd: implement routines for working with .htpasswd

looks good, could we add a Passwds.Check(username, password string) error method?

amery deleted branch dev-amery-ini from amery/jpictl 2023-09-13 15:39:17 +02:00
amery pushed to dev-amery-reflective at amery/jpictl 2023-09-13 15:39:03 +02:00
87dfa0387c reflective [WIP]
06ee82e210 wireguard: ini.Unmarshal() [WIP]
Compare 2 commits »
amery created branch dev-amery-reflective in amery/jpictl 2023-09-13 15:39:03 +02:00