Nagy Károly Gábriel karasz
  • Oradea, Romania
  • Joined on 2018-08-04
karasz deleted branch pr-amery-ceph from amery/jpictl 2024-03-09 11:08:36 +01:00
karasz merged pull request amery/jpictl#41 2024-03-09 11:08:31 +01:00
ceph: prevent osd label update on startup
karasz pushed to main at amery/jpictl 2024-03-09 11:08:31 +01:00
3cafb1a4e2 Merge pull request 'ceph: prevent osd label update on startup' (#41) from pr-amery-ceph into main
14686ff5a8 ceph: prevent osd label update on startup
Compare 2 commits »
karasz commented on pull request amery/jpictl#42 2024-03-05 17:13:48 +01:00
cluster: introduce Region.Cluser and m/{region}/k8s_token to store a cluster's token

What happens if the token file has no non-empty lines?

karasz approved amery/jpictl#44 2024-03-03 13:55:48 +01:00
jpictl: add --version and version command

LGTM

karasz approved amery/jpictl#41 2024-03-03 09:32:03 +01:00
ceph: prevent osd label update on startup

LGTM

karasz approved amery/jpictl#39 2023-10-31 08:47:13 +01:00
cluster: handle regions on filesystem

LGTM

karasz approved amery/jpictl#38 2023-10-30 20:37:02 +01:00
cluster: introduce Machine.Inactive flag

LGTM

karasz approved amery/jpictl#32 2023-10-30 20:36:02 +01:00
jpictl: fix cloud.yaml unmarshalling

+1

karasz commented on pull request amery/jpictl#38 2023-10-30 20:05:45 +01:00
cluster: introduce Machine.Inactive flag

please see above s/Inactive/Active/ and switch logic.

karasz commented on pull request amery/jpictl#38 2023-10-30 20:05:45 +01:00
cluster: introduce Machine.Inactive flag
karasz suggested changes for amery/jpictl#38 2023-10-30 20:05:45 +01:00
cluster: introduce Machine.Inactive flag

see comments

karasz commented on pull request amery/jpictl#38 2023-10-30 20:05:45 +01:00
cluster: introduce Machine.Inactive flag
karasz commented on pull request amery/jpictl#38 2023-10-30 20:05:45 +01:00
cluster: introduce Machine.Inactive flag

Please name the field Active

karasz commented on pull request amery/jpictl#32 2023-10-30 19:58:48 +01:00
jpictl: fix cloud.yaml unmarshalling

Looks a bit strange to me to have switch statement with only 2 cases from which one is default, but otherwise LGTM

I thought you preferred switch over if/else @karasz

This would…

karasz approved amery/jpictl#37 2023-10-30 17:05:33 +01:00
cluster: sort regions, for jpictl dump sake

LGTM

karasz approved amery/jpictl#35 2023-10-30 15:03:14 +01:00
dns: sort zones when writing data

LGTM