Nagy Károly Gábriel karasz
  • Oradea, Romania
  • Joined on 2018-08-04
karasz approved amery/jpictl#34 2023-10-30 15:02:19 +01:00
jpictl: add flags to control the default scan

LGTM

karasz approved amery/jpictl#32 2023-10-30 14:48:35 +01:00
jpictl: fix cloud.yaml unmarshalling

Looks a bit strange to me to have switch statement with only 2 cases from which one is default, but otherwise LGTM

karasz deleted branch pr-amery-wg-iszero from amery/jpictl 2023-10-27 18:11:18 +02:00
karasz pushed to main at amery/jpictl 2023-10-27 18:11:17 +02:00
07d4f462a3 Merge pull request 'wireguard: fix KeyPair.Validate()' (#30)
142ea00577 wireguard: fix KeyPair.Validate()
Compare 2 commits »
karasz merged pull request amery/jpictl#30 2023-10-27 18:11:17 +02:00
wireguard: fix KeyPair.Validate()
karasz approved amery/jpictl#30 2023-10-27 18:10:14 +02:00
wireguard: fix KeyPair.Validate()

LGTM

karasz approved amery/jpictl#29 2023-10-27 18:09:40 +02:00
jpictl: add initial dns add command

LGTM

karasz commented on pull request amery/jpictl#28 2023-10-25 10:57:31 +02:00
dns: refactor record formatting and sort show results

I think here you might want to optimize and compare strings.ToLower(a.Name) to strings.ToLower(b.Name)

karasz commented on pull request amery/jpictl#28 2023-10-25 10:57:31 +02:00
dns: refactor record formatting and sort show results

see comments.

karasz approved amery/jpictl#27 2023-10-24 15:18:41 +02:00
jpictl: introduce jpictl dns show command

LGTM now, thank you.

karasz suggested changes for amery/jpictl#27 2023-10-24 11:51:12 +02:00
jpictl: introduce jpictl dns show command

please update the darvaza resolver version, v0.5.4 i sincompatible with core v0.10.0 as core v0.10.0 does not have Wrapf function anymore.

karasz merged pull request asciigoat/httools#4 2023-09-30 01:48:10 +02:00
light clean up
karasz pushed to master at asciigoat/httools 2023-09-30 01:48:10 +02:00
4395a40036 Merge pull request 'light clean up' (#4)
0fb985026f htpasswd: clean up parser
02235c36bc htpasswd: clean up errors
7b8b0e6700 htpasswd: standarize function names
5941fb013c vscode: add hasher, htpasswd and Passwds to the dictionary
Compare 6 commits »
karasz deleted branch pr-amery-cleanup from asciigoat/httools 2023-09-30 01:48:10 +02:00
karasz approved asciigoat/httools#4 2023-09-30 01:47:20 +02:00
light clean up

LGTM

karasz commented on pull request asciigoat/httools#3 2023-09-28 16:15:59 +02:00
htpasswd: refactor and add Passwd methods

Not sure what you mean

karasz pushed to pr-karasz-refactor at asciigoat/httools 2023-09-28 16:13:40 +02:00
5f5cbeab4f htpasswd: refactor and add Passwd methods