amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dns: refactor record formatting and sort show results #28

Merged
amery merged 3 commits from pr-amery-dns into main 2023-10-27 17:52:20 +02:00
Conversation 3 Commits 3 Files Changed 2
+85 -8
amery commented 2023-10-24 19:14:58 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 3 commits 2023-10-24 19:15:01 +02:00
dns/sync: remove redundant suffix check b6750f8b28 
Signed-off-by: Alejandro Mery <amery@jpi.io>
dns/show: refactor Record formatting c94fa1770c 
Signed-off-by: Alejandro Mery <amery@jpi.io>
dns/show: sort records 70411a2aab 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-10-24 19:15:13 +02:00
amery force-pushed pr-amery-dns from 70411a2aab to 36347abaab 2023-10-24 19:35:38 +02:00 Compare
karasz reviewed 2023-10-25 10:57:31 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

see comments.

see comments.
pkg/dns/record.go Outdated
@@ -41,0 +52,4 @@
return true
case a.Name > b.Name:
return false
}
karasz commented 2023-10-25 10:56:01 +02:00
Owner
Copy Link
Copy Source

I think here you might want to optimize and compare strings.ToLower(a.Name) to strings.ToLower(b.Name)

I think here you might want to optimize and compare `strings.ToLower(a.Name)` to `strings.ToLower(b.Name)`
👍 1
karasz marked this conversation as resolved
amery added 2 commits 2023-10-26 20:48:55 +02:00
dns/show: introduce writeRecords() helper 356322bc94 
to print a whole []libdns.Record

Signed-off-by: Alejandro Mery <amery@jpi.io>
dns/show: sort records 9da49f2d86 
v2: change Name to lower case and Type to upper case before comparing

Signed-off-by: Alejandro Mery <amery@jpi.io>
amery commented 2023-10-26 20:49:36 +02:00
Author
Owner
Copy Link
Copy Source

@karsaz like this?

@karsaz like this?
karasz approved these changes 2023-10-27 10:53:10 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTM

LGTM
🎉 1
amery merged commit e857ff7456 into main 2023-10-27 17:52:20 +02:00
amery deleted branch pr-amery-dns 2023-10-27 17:53:03 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#28
Delete Branch "pr-amery-dns"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?