dns: refactor record formatting and sort show results #28

Merged
amery merged 3 commits from pr-amery-dns into main 2 years ago
amery commented 2 years ago
Owner
There is no content yet.
amery added 3 commits 2 years ago
amery requested review from karasz 2 years ago
amery force-pushed pr-amery-dns from 70411a2aab to 36347abaab 2 years ago
karasz reviewed 2 years ago
karasz left a comment
Owner

see comments.

see comments.
return true
case a.Name > b.Name:
return false
}
karasz commented 2 years ago
Owner

I think here you might want to optimize and compare strings.ToLower(a.Name) to strings.ToLower(b.Name)

I think here you might want to optimize and compare `strings.ToLower(a.Name)` to `strings.ToLower(b.Name)`
karasz marked this conversation as resolved
amery added 2 commits 2 years ago
356322bc94 dns/show: introduce writeRecords() helper
9da49f2d86 dns/show: sort records
Poster
Owner

@karsaz like this?

@karsaz like this?
karasz approved these changes 2 years ago
karasz left a comment
Owner

LGTM

LGTM
amery merged commit e857ff7456 into main 2 years ago
amery deleted branch pr-amery-dns 2 years ago

Reviewers

karasz approved these changes 2 years ago
The pull request has been merged as e857ff7456.
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Loading…
There is no content yet.