amery
/
jpictl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Labels Milestones

dns: refactor record formatting and sort show results #28

Merged
amery merged 3 commits from pr-amery-dns into main 8 months ago
Conversation 1 Commits 3 Files Changed 2
amery commented 8 months ago
Owner
There is no content yet.
amery added 3 commits 8 months ago
b6750f8b28 dns/sync: remove redundant suffix check
c94fa1770c dns/show: refactor Record formatting
70411a2aab dns/show: sort records
amery requested review from karasz 8 months ago
amery force-pushed pr-amery-dns from 70411a2aab to 36347abaab 8 months ago
karasz reviewed 8 months ago
karasz left a comment
Owner

see comments.

see comments.
pkg/dns/record.go Outdated
return true
case a.Name > b.Name:
return false
}
karasz commented 8 months ago
Owner

I think here you might want to optimize and compare strings.ToLower(a.Name) to strings.ToLower(b.Name)

I think here you might want to optimize and compare `strings.ToLower(a.Name)` to `strings.ToLower(b.Name)`
👍 1
karasz marked this conversation as resolved
amery added 2 commits 8 months ago
356322bc94 dns/show: introduce writeRecords() helper
9da49f2d86 dns/show: sort records
amery commented 8 months ago
Poster
Owner

@karsaz like this?

@karsaz like this?
karasz approved these changes 8 months ago
karasz left a comment
Owner

LGTM

LGTM
🎉 1
amery merged commit e857ff7456 into main 8 months ago
amery deleted branch pr-amery-dns 8 months ago

Reviewers

karasz approved these changes 8 months ago
The pull request has been merged as e857ff7456.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
karasz
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pr-amery-dns'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes