amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

jpictl: fix cloud.yaml unmarshalling #32

Merged
amery merged 2 commits from pr-amery-unmarshaltext into main 2023-10-30 20:43:22 +01:00
Conversation 5 Commits 2 Files Changed 2
+27
amery commented 2023-10-28 17:57:33 +02:00
Owner
Copy Link
Copy Source

fix cloud.yaml unmarshalling by implementing UnmarshalText on wireguard endpoint addresses and keys

fix cloud.yaml unmarshalling by implementing UnmarshalText on wireguard endpoint addresses and keys
amery added 2 commits 2023-10-28 17:57:34 +02:00
wireguard: implement UnmarshalText for PrivateKey and PublicKey 1da505fd3d 
Signed-off-by: Alejandro Mery <amery@jpi.io>
wireguard: implement EndpointAddress.UnmarshalText 634941a1ef 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-10-28 17:57:39 +02:00
karasz approved these changes 2023-10-30 14:48:35 +01:00
karasz left a comment
Owner
Copy Link
Copy Source

Looks a bit strange to me to have switch statement with only 2 cases from which one is default, but otherwise LGTM

Looks a bit strange to me to have `switch` statement with only 2 cases from which one is `default`, but otherwise LGTM
amery commented 2023-10-30 19:40:43 +01:00
Author
Owner
Copy Link
Copy Source

Looks a bit strange to me to have switch statement with only 2 cases from which one is default, but otherwise LGTM

I thought you preferred switch over if/else @karasz

> Looks a bit strange to me to have `switch` statement with only 2 cases from which one is `default`, but otherwise LGTM I thought you preferred switch over if/else @karasz
karasz commented 2023-10-30 19:58:47 +01:00
Owner
Copy Link
Copy Source

Looks a bit strange to me to have switch statement with only 2 cases from which one is default, but otherwise LGTM

I thought you preferred switch over if/else @karasz

This would have been an

func....{
if err != nil {
    return err
}

return
}

for anything that has more than 2 branches I prefer switch as it seems to me more appropriate .

> > Looks a bit strange to me to have `switch` statement with only 2 cases from which one is `default`, but otherwise LGTM > > I thought you preferred switch over if/else @karasz This would have been an ```go func....{ if err != nil { return err } return } ``` for anything that has more than 2 branches I prefer `switch` as it seems to me more appropriate .
amery added 2 commits 2023-10-30 20:13:53 +01:00
wireguard: implement UnmarshalText for PrivateKey and PublicKey 7c811d7813 
Signed-off-by: Alejandro Mery <amery@jpi.io>
wireguard: implement EndpointAddress.UnmarshalText 125a4c0dbe 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery commented 2023-10-30 20:14:14 +01:00
Author
Owner
Copy Link
Copy Source

@karasz amended accordingly, and rebased over the current main

@karasz amended accordingly, and rebased over the current `main`
amery requested review from karasz 2023-10-30 20:27:33 +01:00
karasz approved these changes 2023-10-30 20:36:02 +01:00
karasz left a comment
Owner
Copy Link
Copy Source

+1

+1
🎉 1
amery merged commit 5ef6d45ef7 into main 2023-10-30 20:43:22 +01:00
amery deleted branch pr-amery-unmarshaltext 2023-10-30 20:43:22 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#32
Delete Branch "pr-amery-unmarshaltext"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?