amery
/
jpictl
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Labels Milestones

cluster: introduce Machine.Inactive flag #38

Merged
amery merged 3 commits from pr-amery-dns-ignore into main 8 months ago
Conversation 2 Commits 3 Files Changed 5
amery commented 8 months ago
Owner

reflected on disk as none on a file named region

these machines won't be included in the regional or zonal aliases

reflected on disk as `none` on a file named `region` these machines won't be included in the regional or zonal aliases
amery added 3 commits 8 months ago
1580c09746 cluster: add Machine.ReadLines() shortcut
851274954e cluster: introduce Machine.Inactive flag
amery requested review from karasz 8 months ago
karasz requested changes 8 months ago
karasz left a comment
Owner

see comments

see comments
pkg/cluster/machine.go Outdated
ID int
Name string `json:"-" yaml:"-"`
Inactive bool `json:"inactive,omitempty" yaml:"inactive,omitempty"`
karasz commented 8 months ago
Owner

Please name the field Active

Please name the field `Active`
amery commented 8 months ago
Poster
Owner

Active breaks zero-value rules, everything would become inactive by default

`Active` breaks zero-value rules, everything would become inactive by default
pkg/cluster/machine.go Outdated
func (m *Machine) Active() bool {
return !m.Inactive
}
karasz commented 8 months ago
Owner 
func (m *Machine) IsActive() bool {
	return m.Active
}
```go func (m *Machine) IsActive() bool { return m.Active }
amery marked this conversation as resolved
pkg/cluster/machine_scan.go Outdated
for _, r := range data {
switch r {
case "none":
m.Inactive = true
karasz commented 8 months ago
Owner

please see above s/Inactive/Active/ and switch logic.

please see above s/Inactive/Active/ and switch logic.
pkg/cluster/regions.go Outdated
z.ForEachMachine(func(p *Machine) bool {
term = fn(p)
if p.Active() {
karasz commented 8 months ago
Owner 
if p.IsActive() {
...
```go if p.IsActive() { ... ```
👍 1
amery marked this conversation as resolved
amery commented 8 months ago
Poster
Owner

@karasz it's currently called Inactive to deal with the zero value. Active by default, otherwise indicated.

@karasz it's currently called Inactive to deal with the zero value. Active by default, otherwise indicated.
amery added 2 commits 8 months ago
892d849740 cluster: introduce Machine.Inactive flag
amery commented 8 months ago
Poster
Owner

Machine.Active() renamed to Machine.IsActive()

`Machine.Active()` renamed to `Machine.IsActive()`
amery requested review from karasz 8 months ago
karasz approved these changes 8 months ago
karasz left a comment
Owner

LGTM

LGTM
amery merged commit a910bba406 into main 8 months ago
amery deleted branch pr-amery-dns-ignore 8 months ago

Reviewers

karasz approved these changes 8 months ago
The pull request has been merged as a910bba406.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
karasz
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pr-amery-dns-ignore'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes