amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

env: export REGIONS and ZONE{zoneID}_REGION #45

Merged
amery merged 4 commits from pr-amery-env-regions into main 2024-03-19 21:11:50 +01:00
Conversation 3 Commits 4 Files Changed 1
+65 -16
amery commented 2024-03-19 17:48:58 +01:00
Owner
Copy Link
Copy Source
No description provided.
amery added 4 commits 2024-03-19 17:48:59 +01:00
env: use foo= instead of foo="" for empty variables e410797413 
to improve readability

Signed-off-by: Alejandro Mery <amery@jpi.io>
env: add []string writer 3ba721bf7f 
Signed-off-by: Alejandro Mery <amery@jpi.io>
env: add REGIONS list to output 7986e0fd3b 
Signed-off-by: Alejandro Mery <amery@jpi.io>
env: export ZONE{zoneID}_REGION fefbfa16a2 
Signed-off-by: Alejandro Mery <amery@jpi.io>
karasz approved these changes 2024-03-19 19:19:39 +01:00
karasz left a comment
Owner
Copy Link
Copy Source

don't really like _, _ = fmt.Fprintf(&buf, "%v", v) aproach, but at the moment I cannot come up with a better solution. Calling _,_=buf.WriteString(fmt.Sprintf(...blah...)) does not seem any nicer :(

don't really like `_, _ = fmt.Fprintf(&buf, "%v", v)` aproach, but at the moment I cannot come up with a better solution. Calling `_,_=buf.WriteString(fmt.Sprintf(...blah...))` does not seem any nicer :(
amery commented 2024-03-19 21:10:26 +01:00
Author
Owner
Copy Link
Copy Source

@karasz it could be refactored to a panicking MustFprint()

@karasz it could be refactored to a panicking `MustFprint()`
amery merged commit f854d87b16 into main 2024-03-19 21:11:50 +01:00
amery deleted branch pr-amery-env-regions 2024-03-19 21:11:50 +01:00
amery commented 2024-03-19 21:15:53 +01:00
Author
Owner
Copy Link
Copy Source

v0.8.0 tagged

`v0.8.0` tagged
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#45
Delete Branch "pr-amery-env-regions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?