env: export REGIONS and ZONE{zoneID}_REGION #45

Merged

amery merged 4 commits from pr-amery-env-regions into main 9 months ago

amery commented 9 months ago

Owner

There is no content yet.

amery added 4 commits 9 months ago

e410797413 env: use foo= instead of foo="" for empty variables

to improve readability

Signed-off-by: Alejandro Mery <amery@jpi.io>

3ba721bf7f env: add []string writer

Signed-off-by: Alejandro Mery <amery@jpi.io>

7986e0fd3b env: add REGIONS list to output

Signed-off-by: Alejandro Mery <amery@jpi.io>

fefbfa16a2 env: export ZONE{zoneID}_REGION

Signed-off-by: Alejandro Mery <amery@jpi.io>

karasz approved these changes 9 months ago

karasz left a comment

Owner

don't really like _, _ = fmt.Fprintf(&buf, "%v", v) aproach, but at the moment I cannot come up with a better solution. Calling _,_=buf.WriteString(fmt.Sprintf(...blah...)) does not seem any nicer :(

amery commented 9 months ago

Poster

Owner

@karasz it could be refactored to a panicking MustFprint()

amery merged commit f854d87b16 into main 9 months ago

amery deleted branch pr-amery-env-regions 9 months ago

amery referenced this issue from a commit 9 months ago

Merge pull request 'env: export REGIONS and ZONE{zoneID}_REGION' (#45) from pr-amery-env-regions into main

amery commented 9 months ago

Poster

Owner

v0.8.0 tagged

Reviewers

karasz approved these changes 9 months ago

The pull request has been merged as f854d87b16.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.