amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

zones: Env: allow multiple gateways and drop unused ZONE{zoneID}_IP #4

Merged
amery merged 3 commits from pr-amery-env into main 2023-08-28 18:09:00 +02:00
Conversation 3 Commits 3 Files Changed 1
+37 -21
1 changed files with 37 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit de45fa6c30 - Show all commits
pkg/zones/env.go
+37 -21
View File
@@ -22,11 +22,23 @@ func (m *Zones) Env(export bool) *Env {
}
}
// Zones returns the list of Zone IDs
func (m *Env) Zones() []int {
var zones []int
m.ForEachZone(func(z *Zone) bool {
zones = append(zones, z.ID)
return false
})
return zones
}
// WriteTo generates environment variables for shell scripts
func (m *Env) WriteTo(w io.Writer) (int64, error) {
var buf bytes.Buffer
m.writeEnvVarFn(&buf, genEnvZones, "ZONES")
m.writeEnvVarInts(&buf, m.Zones(), "ZONES")
m.ForEachZone(func(z *Zone) bool {
m.writeEnvZone(&buf, z)
return false
@@ -51,14 +63,23 @@ func (m *Env) writeEnvZone(w io.Writer, z *Zone) {
}
}
func (m *Env) writeEnvVarFn(w io.Writer, fn func(*Env) string, name string, args ...any) {
var value string
func (m *Env) writeEnvVarInts(w io.Writer, value []int, name string, args ...any) {
var s string
amery marked this conversation as resolved Outdated
karasz commented 2023-08-28 17:54:30 +02:00
Outdated
Review
Copy Link
Copy Source

I would make it like:

if n := len(value); n > 0 {
	var buffer bytes.Buffer
    for i, v := range value {
    	buffer.WriteString(fmt.Sprintf("%v", v))
    }
}
I would make it like: ```go if n := len(value); n > 0 { var buffer bytes.Buffer for i, v := range value { buffer.WriteString(fmt.Sprintf("%v", v)) } } ```
👍 1
amery commented 2023-08-28 18:00:21 +02:00
Outdated
Review
Copy Link
Copy Source

so buffered instead of joined. agreed

so buffered instead of joined. agreed
amery commented 2023-08-28 18:07:46 +02:00
Outdated
Review
Copy Link
Copy Source

slightly different to handle the space delimiters, but commit amended to use a bytes.Buffer instead of strings.Join @karasz

slightly different to handle the space delimiters, but commit amended to use a `bytes.Buffer` instead of `strings.Join` @karasz
if fn != nil {
value = fn(m)
if n := len(value); n > 0 {
var buf bytes.Buffer
for i, v := range value {
if i != 0 {
_, _ = fmt.Fprint(&buf, " ")
}
_, _ = fmt.Fprintf(&buf, "%v", v)
}
s = buf.String()
}
m.writeEnvVar(w, value, name, args...)
m.writeEnvVar(w, s, name, args...)
}
func (m *Env) writeEnvVar(w io.Writer, value string, name string, args ...any) {
@@ -79,23 +100,18 @@ func (m *Env) writeEnvVar(w io.Writer, value string, name string, args ...any) {
}
}
func genEnvZones(m *Env) string {
var s []string
m.ForEachZone(func(z *Zone) bool {
s = append(s, fmt.Sprintf("%v", z.ID))
return false
})
return strings.Join(s, " ")
}
func genEnvZoneNodes(z *Zone) string {
s := make([]string, 0, len(z.Machines))
for _, p := range z.Machines {
s = append(s, p.Name)
if n := z.Len(); n > 0 {
s := make([]string, 0, n)
z.ForEachMachine(func(p *Machine) bool {
s = append(s, p.Name)
return false
})
return strings.Join(s, " ")
}
return strings.Join(s, " ")
return ""
}
func getRingZeroGatewayID(z *Zone) int {