zones: fix `jpictl dump` by explicitly omitting Machine.logger and Zone.logger #15

Merged

amery merged 1 commits from pr-amery-dump into main 10 months ago

amery commented 10 months ago

Owner

if they were fields, as in Zones, they would be ignored automatically.
but they aren't

amery added 1 commit 10 months ago

32046fc1ec zones: fix `jpictl dump` by explicitly omitting Machine.logger and Zone.logger

if they were fields, as in Zones, they would be ignored automatically.
but they aren't

Signed-off-by: Alejandro Mery <amery@jpi.io>

amery requested review from karasz 10 months ago

karasz reviewed 10 months ago

pkg/zones/machine.go

												
					type Machine struct {
				
						zone *Zone
				
						logger
				
						zone   *Zone

karasz commented 10 months ago

Owner

this looks like fmt should have caught it, but anyways what are we? Python? since when whitespace counts?

karasz approved these changes 10 months ago

karasz left a comment

Owner

ok

amery merged commit 7795610caf into main 10 months ago

amery deleted branch pr-amery-dump 10 months ago

amery referenced this issue from a commit 10 months ago

Merge pull request 'zones: fix `jpictl dump` by explicitly omitting Machine.logger and Zone.logger' (#15)

amery commented 10 months ago

Poster

Owner

v0.5.4 tagged

Reviewers

karasz approved these changes 10 months ago

The pull request has been merged as 7795610caf.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.