zones: fix `jpictl dump` by explicitly omitting Machine.logger and Zone.logger #15

Merged

amery merged 1 commits from pr-amery-dump into main 2 years ago

amery commented 2 years ago

Owner

if they were fields, as in Zones, they would be ignored automatically.
but they aren't

amery added 1 commit 2 years ago

32046fc1ec zones: fix `jpictl dump` by explicitly omitting Machine.logger and Zone.logger

if they were fields, as in Zones, they would be ignored automatically.
but they aren't

Signed-off-by: Alejandro Mery <[email protected]>

amery requested review from karasz 2 years ago

karasz reviewed 2 years ago

pkg/zones/machine.go

												
					type Machine struct {
				
						zone *Zone
				
						logger
				
						zone   *Zone

karasz commented 2 years ago

Owner

this looks like fmt should have caught it, but anyways what are we? Python? since when whitespace counts?

karasz approved these changes 2 years ago

karasz left a comment

Owner

ok

amery merged commit 7795610caf into main 2 years ago

amery deleted branch pr-amery-dump 2 years ago

amery referenced this issue from a commit 2 years ago

Merge pull request 'zones: fix `jpictl dump` by explicitly omitting Machine.logger and Zone.logger' (#15)

amery commented 2 years ago

Poster

Owner

v0.5.4 tagged

Reviewers

karasz approved these changes 2 years ago

The pull request has been merged as 7795610caf.

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.