amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

zones: fix jpictl dump by explicitly omitting Machine.logger and Zone.logger #15

Merged
amery merged 1 commits from pr-amery-dump into main 2023-09-08 21:01:26 +02:00
Conversation 3 Commits 1 Files Changed 2
+4 -4
amery commented 2023-09-08 15:14:26 +02:00
Owner
Copy Link
Copy Source

if they were fields, as in Zones, they would be ignored automatically.
but they aren't

if they were fields, as in Zones, they would be ignored automatically. but they aren't
amery added 1 commit 2023-09-08 15:14:26 +02:00
zones: fix jpictl dump by explicitly omitting Machine.logger and Zone.logger 32046fc1ec 
if they were fields, as in Zones, they would be ignored automatically.
but they aren't

Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-09-08 15:14:30 +02:00
karasz reviewed 2023-09-08 15:47:47 +02:00
pkg/zones/machine.go
@@ -11,3 +11,2 @@
type Machine struct {
zone *Zone
logger
zone *Zone
karasz commented 2023-09-08 15:47:47 +02:00
Owner
Copy Link
Copy Source

this looks like fmt should have caught it, but anyways what are we? Python? since when whitespace counts?

this looks like `fmt` should have caught it, but anyways what are we? Python? since when whitespace counts?
karasz approved these changes 2023-09-08 15:48:00 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

ok

ok
amery merged commit 7795610caf into main 2023-09-08 21:01:26 +02:00
amery deleted branch pr-amery-dump 2023-09-08 21:01:26 +02:00
amery commented 2023-09-08 21:02:18 +02:00
Author
Owner
Copy Link
Copy Source

v0.5.4 tagged

`v0.5.4` tagged
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#15
Delete Branch "pr-amery-dump"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?