amery
/
jpictl
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Labels Milestones

zones: fix `jpictl dump` by explicitly omitting Machine.logger and Zone.logger #15

Merged
amery merged 1 commits from pr-amery-dump into main 1 year ago
Conversation 1 Commits 1 Files Changed 2
amery commented 1 year ago
Owner

if they were fields, as in Zones, they would be ignored automatically.
but they aren't

if they were fields, as in Zones, they would be ignored automatically. but they aren't
amery added 1 commit 1 year ago
32046fc1ec zones: fix `jpictl dump` by explicitly omitting Machine.logger and Zone.logger
amery requested review from karasz 1 year ago
karasz reviewed 1 year ago
pkg/zones/machine.go
type Machine struct {
zone *Zone
logger
zone *Zone
karasz commented 1 year ago
Owner

this looks like fmt should have caught it, but anyways what are we? Python? since when whitespace counts?

this looks like `fmt` should have caught it, but anyways what are we? Python? since when whitespace counts?
karasz approved these changes 1 year ago
karasz left a comment
Owner

ok

ok
amery merged commit 7795610caf into main 1 year ago
amery deleted branch pr-amery-dump 1 year ago
amery commented 1 year ago
Poster
Owner

v0.5.4 tagged

`v0.5.4` tagged

Reviewers

karasz approved these changes 1 year ago
The pull request has been merged as 7795610caf.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
karasz
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pr-amery-dump'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes