amery/jpictl
2
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ceph: add initial ceph support. reading and writing m/ceph.conf #9

Merged
amery merged 13 commits from pr-amery-ceph into main 2023-09-05 21:35:53 +02:00
Conversation 5 Commits 13 Files Changed 13
+561
amery commented 2023-09-05 15:47:15 +02:00
Owner
Copy Link
Copy Source
No description provided.
amery added 13 commits 2023-09-05 15:47:16 +02:00
vscode: add ceph to the dictionary a8849b747c 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: introduce Zones.CephFSID and Zones.GetCephFSID() 0fb8c1d44b 
the accessor doesn't generate one if needed yet

Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: introduce Machine.CephMonitor field 025b9072b4 
Signed-off-by: Alejandro Mery <amery@jpi.io>
ceph: add NewConfigFromReader() and initial ceph.conf parser d4757bebc2 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: introduce Zones.GetCephConfig() accessor for m/ceph.conf 7489b15c52 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: introduce Zone.GetCephMonitors() 226d529223 
returning the local ceph monitors and setting one
if there is none. non-gateway nodes are preferred
when setting a monitor automatically

Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: introduce GenCephConfig() c083a144ea 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: set Machine.CephMonitor if its referenced as monitor on ceph.conf 564a6c8af2 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: store ceph FSID on scan d8657770d5 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: extend scan to ensure every zone has a ceph monitor cc7526ceb5 
Signed-off-by: Alejandro Mery <amery@jpi.io>
env: set ceph monitors variables 75dee617ef 
they indicate the ceph monitors on the specified zone

* MON{zoneID}_NAME
* MON{zoneID}_ID
* MON{zoneID}_IP

Signed-off-by: Alejandro Mery <amery@jpi.io>
ceph: zones.Zones.WriteCephConfig() and ceph.Config.WriteTo() 5e57fe5f30 
Signed-off-by: Alejandro Mery <amery@jpi.io>
jpictl: write m/ceph.conf on sync 4200db12cb 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery requested review from karasz 2023-09-05 15:47:25 +02:00
karasz requested changes 2023-09-05 16:08:48 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

Fine and dandy but segfaults if ceph.conf is not in the root of the machines. Please allow for ceph.conf to be in the proper place.

Fine and dandy but segfaults if ceph.conf is not in the root of the machines. Please allow for ceph.conf to be in the proper place.
👍 1
karasz reviewed 2023-09-05 16:45:43 +02:00
pkg/ceph/config_parser.go Outdated
@@ -0,0 +37,4 @@
}
// revive:disable:cyclomatic
// revive:disable:cognitive-complexity
karasz commented 2023-09-05 16:45:43 +02:00
Owner
Copy Link
Copy Source

Please also add // TODO: or // FIXME: explaining why this is needed

Please also add // TODO: or // FIXME: explaining why this is needed
👍 1
karasz marked this conversation as resolved
amery added 10 commits 2023-09-05 18:48:21 +02:00
ceph: add NewConfigFromReader() and initial ceph.conf parser 94011a3a03 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: introduce Zones.GetCephConfig() accessor for m/ceph.conf 05e04c758b 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: introduce Zone.GetCephMonitors() e3ab931eb1 
returning the local ceph monitors and setting one
if there is none. non-gateway nodes are preferred
when setting a monitor automatically

Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: introduce GenCephConfig() bf4bfeb3fc 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: set Machine.CephMonitor if its referenced as monitor on ceph.conf 77ad016e99 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: store ceph FSID on scan b772ec0a3d 
Signed-off-by: Alejandro Mery <amery@jpi.io>
zones: extend scan to ensure every zone has a ceph monitor cea8362fe6 
Signed-off-by: Alejandro Mery <amery@jpi.io>
env: set ceph monitors variables fe081a4297 
they indicate the ceph monitors on the specified zone

* MON{zoneID}_NAME
* MON{zoneID}_ID
* MON{zoneID}_IP

Signed-off-by: Alejandro Mery <amery@jpi.io>
ceph: zones.Zones.WriteCephConfig() and ceph.Config.WriteTo() ac87757b06 
Signed-off-by: Alejandro Mery <amery@jpi.io>
jpictl: write m/ceph.conf on sync f10ea1dc22 
Signed-off-by: Alejandro Mery <amery@jpi.io>
amery commented 2023-09-05 18:49:35 +02:00
Author
Owner
Copy Link
Copy Source

bug fixed and // TODO: added to the complex parser function

bug fixed and `// TODO:` added to the complex parser function
amery requested review from karasz 2023-09-05 18:49:38 +02:00
karasz approved these changes 2023-09-05 20:58:46 +02:00
karasz left a comment
Owner
Copy Link
Copy Source

LGTMN

LGTMN
🚀 1
amery merged commit 1fe1cf940d into main 2023-09-05 21:35:53 +02:00
amery deleted branch pr-amery-ceph 2023-09-05 21:36:11 +02:00
amery commented 2023-09-05 21:37:24 +02:00
Author
Owner
Copy Link
Copy Source

v0.5.0 tagged

`v0.5.0` tagged
Sign in to join this conversation.
Reviewers
No Reviewers
karasz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
karasz (Nagy Károly Gábriel) amery (Alejandro Mery)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: amery/jpictl#9
Delete Branch "pr-amery-ceph"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?