amery
/
jpictl
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity
Labels Milestones

ceph: add initial ceph support. reading and writing m/ceph.conf #9

Merged
amery merged 13 commits from pr-amery-ceph into main 2 years ago
Conversation 2 Commits 13 Files Changed 13
amery commented 2 years ago
Owner
There is no content yet.
amery added 13 commits 2 years ago
0fb8c1d44b zones: introduce Zones.CephFSID and Zones.GetCephFSID()
226d529223 zones: introduce Zone.GetCephMonitors()
75dee617ef env: set ceph monitors variables
amery requested review from karasz 2 years ago
karasz requested changes 2 years ago
karasz left a comment
Owner

Fine and dandy but segfaults if ceph.conf is not in the root of the machines. Please allow for ceph.conf to be in the proper place.

Fine and dandy but segfaults if ceph.conf is not in the root of the machines. Please allow for ceph.conf to be in the proper place.
👍 1
karasz reviewed 2 years ago
pkg/ceph/config_parser.go Outdated
}
// revive:disable:cyclomatic
// revive:disable:cognitive-complexity
karasz commented 2 years ago
Owner

Please also add // TODO: or // FIXME: explaining why this is needed

Please also add // TODO: or // FIXME: explaining why this is needed
👍 1
karasz marked this conversation as resolved
amery added 10 commits 2 years ago
e3ab931eb1 zones: introduce Zone.GetCephMonitors()
fe081a4297 env: set ceph monitors variables
amery commented 2 years ago
Poster
Owner

bug fixed and // TODO: added to the complex parser function

bug fixed and `// TODO:` added to the complex parser function
amery requested review from karasz 2 years ago
karasz approved these changes 2 years ago
karasz left a comment
Owner

LGTMN

LGTMN
🚀 1
amery merged commit 1fe1cf940d into main 2 years ago
amery deleted branch pr-amery-ceph 2 years ago
amery commented 2 years ago
Poster
Owner

v0.5.0 tagged

`v0.5.0` tagged

Reviewers

karasz approved these changes 2 years ago
The pull request has been merged as 1fe1cf940d.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
karasz
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'pr-amery-ceph'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes